> -----Original Message-----
> From: Amber, Kumar <kumar.am...@intel.com>
> Sent: Wednesday 23 March 2022 12:40
> To: ovs-dev@openvswitch.org
> Cc: f...@sysclose.org; i.maxim...@ovn.org; Ferriter, Cian
> <cian.ferri...@intel.com>; Stokes, Ian
> <ian.sto...@intel.com>; echau...@redhat.com; Van Haaren, Harry
> <harry.van.haa...@intel.com>; Amber,
> Kumar <kumar.am...@intel.com>
> Subject: [PATCH v7 0/4] IPv4 Hashing AVX512 Optimizations
>
> Hashing Optimization are also included which can further
> improve performance by approximately 10%.
>
Hi Amber,
I'm taking a look at this series.
I can see a 9% improvement in my performance testing. I'm using the DPDK PCAP
PMD with the infinite_rx=1 which means OVS has to calculate the 5tuple hash.
I can also see in perf top that before the patchset, miniflow_hash_5tuple()
takes ~8% of cycles, and afterwards it's not used and mfex_avx512_ip_udp()
takes more cycles since the newly introduced mfex_5tuple_hash_ipv4() function
is inlined under it.
I'll leave more comments on the actual patches in the series.
Thanks,
Cian
> ---
> v7:
> - Split Ipv4 Hahsing to separate Patchset
> v6:
> - Reorder Patches in the Patchset.
> v5:
> - Add Ipv6 and TCP packet length checks.
> v4:
> - rebase to master.
> - use static key lenghts for different packet types.
> v3:
> - rebase to master.
> v2:
> - fix the CI build.
> - fix check-patch for co-author.
> ---
>
> Kumar Amber (4):
> dpif-netdev/mfex: Add ipv4 profile based hashing.
> dpif-netdev/mfex: Add packet hash check to autovalidator.
> dpif-netdev/mfex: Avoid hashing when opt mfex called.
> tests/mfex: Improve pcap script for mfex tests.
>
> NEWS | 2 +
> lib/dpif-netdev-avx512.c | 6 +--
> lib/dpif-netdev-extract-avx512.c | 65 ++++++++++++++++++++++++++++++
> lib/dpif-netdev-private-extract.c | 12 ++++++
> tests/automake.mk | 1 -
> tests/mfex_fuzzy.py | 55 ++++++++++++++++---------
> tests/pcap/mfex_test.pcap | Bin 416 -> 0 bytes
> tests/system-dpdk.at | 23 +++++++----
> 8 files changed, 134 insertions(+), 30 deletions(-)
> delete mode 100644 tests/pcap/mfex_test.pcap
>
> --
> 2.25.1
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev