> -----Original Message-----
> From: Amber, Kumar <kumar.am...@intel.com>
> Sent: Wednesday 23 March 2022 12:40
> To: ovs-dev@openvswitch.org
> Cc: f...@sysclose.org; i.maxim...@ovn.org; Ferriter, Cian
> <cian.ferri...@intel.com>; Stokes, Ian
> <ian.sto...@intel.com>; echau...@redhat.com; Van Haaren, Harry
> <harry.van.haa...@intel.com>; Amber,
> Kumar <kumar.am...@intel.com>
> Subject: [PATCH v7 4/4] tests/mfex: Improve pcap script for mfex tests.
>
> The mfex pcap generation script is improved for varied length
> traffic and also removes the hard coded mfex_pcap and instead uses
> the script itself to generate complex traffic patterns for testing.
>
> Signed-off-by: Kumar Amber <kumar.am...@intel.com>
Hi Amber,
I like idea of removing the binary PCAP file and instead generating the PCAPs
on the fly. That way we can see what packets are being generated from the
mfex_fuzzy.py script.
I've run the MFEX unit tests before and after the patch series. They are all
passing:
6: OVS-DPDK - MFEX Autovalidator ok
7: OVS-DPDK - MFEX Autovalidator Fuzzy ok
8: OVS-DPDK - MFEX Configuration ok
But I see increased MFEX unit test execution time:
Before patch:
~/ovs# time make check-dpdk TESTSUITEFLAGS='-k MFEX -d'
<snip>
real 0m43.936s
user 0m26.577s
sys 0m0.881s
43 seconds
After patch:
~/ovs# time make check-dpdk TESTSUITEFLAGS='-k MFEX -d'
<snip>
real 4m24.100s
user 4m2.374s
sys 0m3.014s
4 minutes and 24 seconds
Its seems that a lot of time is spent calling mfex_fuzzy.py. Have you seen this
behaviour too? I wonder if there's any way to improve the execution of
mfex_fuzzy.py. It looks like we write each packet to the file 1 at a time.
Maybe we can write packet to file once at the end of the script?
Thanks,
Cian
<snip patch diff away>
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
