Thanks, Eelco, All the review helped to improve the patch 😊 Regards Amber
> -----Original Message----- > From: Eelco Chaudron <echau...@redhat.com> > Sent: Friday, May 27, 2022 2:07 PM > To: Amber, Kumar <kumar.am...@intel.com> > Cc: ovs-dev@openvswitch.org; Ferriter, Cian <cian.ferri...@intel.com>; > i.maxim...@ovn.org; Stokes, Ian <ian.sto...@intel.com>; Van Haaren, Harry > <harry.van.haa...@intel.com> > Subject: Re: [PATCH v6] tests/mfex: Improve pcap script for mfex tests. > > > > On 26 May 2022, at 13:55, Kumar Amber wrote: > > > The mfex pcap generation script is improved for varied length traffic > > and also removes the hard coded mfex_pcap and instead uses the script > > itself to generate complex traffic patterns for testing. > > > > Signed-off-by: Kumar Amber <kumar.am...@intel.com> > > Acked-by: Cian Ferriter <cian.ferri...@intel.com> > > > > --- > > v6: > > - move the pcap generation to individual test folders. > > - removed relative file path to full path. > > - fix minor nits. > > v5: > > - fix mac and ip address generation. > > v4: > > - Fix MAC and L4 ports to a value. > > - Generate Ip addresses in fixed range. > > v3: > > - Fix comments(Eelco). > > - Script generates mac/ip/l4_ports in a fixed range. > > v2: > > - Add huge page test-skip. > > - Change core id to 3 to 0 to allow the mfex config test-case > > to run on any system. > > Thanks for working on all the revisions! This version looks fine to me! > > Acked-by: Eelco Chaudron <echau...@redhat.com> _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
