<snip unrelated diffs and discussion>
> >>> diff --git a/tests/system-dpdk.at b/tests/system-dpdk.at index
> >>> 7d2715c4a..ac83e5a57 100644
> >>> --- a/tests/system-dpdk.at
> >>> +++ b/tests/system-dpdk.at
> >>> @@ -226,17 +226,19 @@ dnl
> >>> ----------------------------------------------------------------------
> >>> ----
> >>> dnl Add standard DPDK PHY port
> >>> AT_SETUP([OVS-DPDK - MFEX Autovalidator])
> >>> AT_KEYWORDS([dpdk])
> >>> -
> >>> +OVS_DPDK_PRE_CHECK()
> >>> OVS_DPDK_START()
> >>> -
> >>> -dnl Add userspace bridge and attach it to OVS AT_CHECK([ovs-vsctl
> >>> add-br br0 -- set bridge br0 datapath_type=netdev])
> >>> -AT_CHECK([ovs-vsctl add-port br0 p1 -- set Interface p1 type=dpdk
> >>> options:dpdk-
> >> devargs=net_pcap1,rx_pcap=$srcdir/pcap/mfex_test.pcap,inf
> >>> inite_rx=1], [], [stdout], [stderr]) -AT_CHECK([ovs-vsctl show], [],
> >>> [stdout])
> >>> -
> >>> AT_SKIP_IF([! ovs-appctl dpif-netdev/miniflow-parser-get | sed 1,4d |
> >>> grep "True"], [], [dnl
> >>> ])
> >>>
> >>> +AT_SKIP_IF([! $PYTHON3 -c "import scapy"], [], [])
> >>> +AT_CHECK([$PYTHON3 $srcdir/mfex_fuzzy.py $srcdir 2000], [], [stdout])
> >>
> >> Have you tested this patch on an MFEX machine on a clean branch? I do not
> >> have an AVX512 machine, but if I move this above the check I get errors due
> >> to missing tests/pcap/ directory.
> >>
> >> --- /dev/null 2022-04-25 09:31:38.866748964 +0200
> >> +++
> >> /home/echaudron/Documents/review/ovs_akumar_mfeximp/ovs_github/te
> >> sts/system-dpdk-testsuite.dir/at-groups/6/stderr 2022-05-25
> >> 11:17:40.116614366 +0200
> >> @@ -0,0 +1,6 @@
> >> +Traceback (most recent call last):
> >> + File
> >> "/home/echaudron/Documents/review/ovs_akumar_mfeximp/ovs_github/t
> >> ests/system-dpdk-testsuite.dir/6/../.././mfex_fuzzy.py", line 22, in
> >> <module>
> >> + pktdump = PcapWriter(path, append=False, sync=True)
> >> + File "/usr/lib/python3.10/site-packages/scapy/utils.py", line 1686, in
> >> __init__
> >> + self.f = open(filename, append and "ab" or "wb", bufsz)
> >> +FileNotFoundError: [Errno 2] No such file or directory:
> >> '../.././pcap/fuzzy.pcap'
> >> stdout:
> >>
> >
> > Yes, I have tested on AVX512 machine.
> >
> > If you compare this patch with the reorder you suggested in the first
> > reply, I had to do a bit of
> > Reorder in the first suggestion because I saw the same error:
> >
> > We need to add a port to ovs to run the "get-mfex" command for skip to work
> > thus kept the
> > Add port before the AT_SKIP("mfex-get).
> >
> > But kept the Pcap generation then subsequent netdev bridge addition later
> > after skip.
> > If you move the netdev bridge addition before pcap generation, you will get
> > the file missing error.
>
> This is not the problem, you removed the only test/pcap/… file which will
> result in the pcap directory
> being removed from the GitHub repo, so it no longer exist, hence you get the
> error.
>
> Whoever reviewed your patches should have run into this if he applied the
> patches thought git am.
>
Hi Eelco and Amber,
Oops, I missed this, good catch. While I did apply and test this patch, the key
thing I missed was making sure all files are cleaned up from previous OVS
builds and tests. So I was testing with a still existing test/pcap/ directory.
Apologies for that. I will make sure to test patches from a clean OVS repo
state in the future.
I tested this patch again after a "git clean -fdx" to make clean up build and
test files and can reproduce the error that Eelco sees:
+Traceback (most recent call last):
+ File "../.././mfex_fuzzy.py", line 18, in <module>
+ pktdump = PcapWriter(path, append=False, sync=True)
+ File "/usr/local/lib/python3.8/dist-packages/scapy/utils.py", line 1686, in
__init__
+ self.f = open(filename, append and "ab" or "wb", bufsz)
+FileNotFoundError: [Errno 2] No such file or directory:
'../.././pcap/fuzzy.pcap'
stdout:
./system-dpdk.at:232: exit code was 1, expected 0
<snip unrelated diffs and discussion>
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
