[ -z $string ] needs double quotes to handle zero-length strings properly. Fixes: 09dc4866fd32 ("Handle re-used pids in pidfile_is_running") Signed-off-by: Ihar Hrachyshka <ihrac...@redhat.com> --- utilities/ovn-ctl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/utilities/ovn-ctl b/utilities/ovn-ctl index e2f05915b..46cbac4c2 100755 --- a/utilities/ovn-ctl +++ b/utilities/ovn-ctl @@ -43,7 +43,7 @@ ovn_ic_db_conf_file="$ovn_etcdir/ovn-ic-db-params.conf" pidfile_is_running () { pidfile=$1 cmd=$2 - test -e "$pidfile" && [ -s "$pidfile" ] && pid=`cat "$pidfile"` && pid_exists "$pid" && [ -z $cmd -o pid_comm_check "$cmd" "$pid" ] + test -e "$pidfile" && [ -s "$pidfile" ] && pid=`cat "$pidfile"` && pid_exists "$pid" && [ -z "$cmd" -o pid_comm_check "$cmd" "$pid" ] } >/dev/null 2>&1 stop_nb_ovsdb() { -- 2.34.1 _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev