Hi, sorry for that, I didn't really test it with -fake-multinode
before. Sent v2 with a simplified version of the function that I
tested with -fake-multinode now and no longer experience the issue you
reported.
Ihar
On Mon, Jun 13, 2022 at 5:01 PM Numan Siddique <num...@ovn.org> wrote:
>
> On Mon, Jun 13, 2022 at 3:00 PM Ihar Hrachyshka <ihrac...@redhat.com> wrote:
> >
> > Signed-off-by: Ihar Hrachyshka <ihrac...@redhat.com>
>
> With this patch I also applied, I see the below error
>
> /usr/share/ovn/scripts/ovn-ctl: line 53: test: syntax error: `-s' unexpected
>
> I think it should be - test -s "$pidfile" && ....
>
>
> Thanks
> Numan
>
> > ---
> > utilities/ovn-ctl | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/utilities/ovn-ctl b/utilities/ovn-ctl
> > index 46cbac4c2..5d74b48ed 100755
> > --- a/utilities/ovn-ctl
> > +++ b/utilities/ovn-ctl
> > @@ -43,7 +43,7 @@ ovn_ic_db_conf_file="$ovn_etcdir/ovn-ic-db-params.conf"
> > pidfile_is_running () {
> > pidfile=$1
> > cmd=$2
> > - test -e "$pidfile" && [ -s "$pidfile" ] && pid=`cat "$pidfile"` &&
> > pid_exists "$pid" && [ -z "$cmd" -o pid_comm_check "$cmd" "$pid" ]
> > + test [ -s "$pidfile" ] && pid=`cat "$pidfile"` && pid_exists "$pid" &&
> > [ -z "$cmd" -o pid_comm_check "$cmd" "$pid" ]
> > } >/dev/null 2>&1
> >
> > stop_nb_ovsdb() {
> > --
> > 2.34.1
> >
> > _______________________________________________
> > dev mailing list
> > d...@openvswitch.org
> > https://mail.openvswitch.org/mailman/listinfo/ovs-dev
> >
>
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
