> -----Original Message----- > From: Amber, Kumar <kumar.am...@intel.com> > Sent: Tuesday, June 28, 2022 9:45 AM > To: ovs-dev@openvswitch.org > Cc: echau...@redhat.com; i.maxim...@ovn.org; Ferriter, Cian > <cian.ferri...@intel.com>; Stokes, Ian <ian.sto...@intel.com>; > f...@sysclose.org; > Van Haaren, Harry <harry.van.haa...@intel.com>; Amber, Kumar > <kumar.am...@intel.com> > Subject: [PATCH v3 0/5] DPIF AVX512 Recirculation > > The patch adds support for recirculation of packets in AVX512 > DPIF which would allow for processing tunneled packets.
Some general feedback on this patchset, having reviewed the code in detail. 1) we need to ensure that MFEX-avx512 behave correctly when used from a recirc context (today it only does outer). This can be done using the MFEX autovalidator, but will likely require some minor modifications to make it "recirc aware". At that point, the MFEX autovalidator can correctly validate inner & outer packets, so gives confidence in the usage of optimized MFEX implementations, from both inner & outer contexts. 2) Today, the MFEX optimized routines are *not* capable of handling recirc packets. That was previously included in this patchset, but was split out to a separate patchset to ease reviews & streamline merging. (The v1 of this series was called "DPIF+MFEX Inner vxlan opts": https://patchwork.ozlabs.org/project/openvswitch/cover/20220321061441.1833575-1-kumar.am...@intel.com/) Once 1) and 2) are in place, autovalidation should identify that current MFEX cannot operate on inner packets, and the DPIF should not execute the optimized MFEX routines for *inner* packets (yet). Enabling MFEX on inner will be done for 2.19 release, improving the optimized avx512 MFEX handling for recirculated/inner packets (as was present in v1 linked above already). For a high-level overview, hope that makes sense. @Amber, please incorporate the above into the next version. Regards, -Harry _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
