Hi Emma, Thanks for the patch, generally looks good, one comment below.
<snipped> > diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c index > 58be9d0f0..b618ecba0 100644 > --- a/lib/dpif-netdev.c > +++ b/lib/dpif-netdev.c > @@ -63,6 +63,7 @@ > #include "netdev-vport.h" > #include "netlink.h" > #include "odp-execute.h" > +#include "odp-execute-private.h" This include is not required here anymore. OTOH Ilya's suggestion to move any changes from dpif-netdev would render my point moot as we wouldn't be changing this file anyway. > #include "odp-util.h" > #include "openvswitch/dynamic-string.h" > #include "openvswitch/list.h" > diff --git a/lib/odp-execute-private.c b/lib/odp-execute-private.c index > 01722dc9b..442837fa5 100644 > --- a/lib/odp-execute-private.c > +++ b/lib/odp-execute-private.c > @@ -67,6 +67,18 @@ odp_execute_action_set(const char *name) > return NULL; > } > <snipped> Thanks and regards Sunil _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
