> -----Original Message-----
> From: Pai G, Sunil <[email protected]>
> Sent: Tuesday 12 July 2022 12:22
> To: Finn, Emma <[email protected]>; [email protected]
> Cc: [email protected]; [email protected]; Van Haaren, Harry
> <[email protected]>; Amber, Kumar <[email protected]>
> Subject: RE: [ovs-dev] [v8 06/10] odp-execute: Add ISA implementation of
> actions.
>
> Hi Emma,
>
> Thanks for the patch, couple of comments inline.
>
> <snipped>
>
> > diff --git a/lib/automake.mk b/lib/automake.mk index
> > 5c3b05f6b..e6335ccac
> > 100644
> > --- a/lib/automake.mk
> > +++ b/lib/automake.mk
> > @@ -31,6 +31,9 @@ lib_LTLIBRARIES += lib/libopenvswitchavx512.la
> > lib_libopenvswitch_la_LIBADD += lib/libopenvswitchavx512.la
> > lib_libopenvswitchavx512_la_CFLAGS = \
> > -mavx512f \
> > + -mavx512bw \
> > + -mavx512vl \
> > + -mavx512dq \
>
> We don't need these flags here anymore as they are covered below.
> Seems like leftovers from rebase, we can remove them.
Yes, this change will be removed in next version.
>
> > -mbmi \
> > -mbmi2 \
> > -fPIC \
> > @@ -44,7 +47,8 @@ lib_libopenvswitchavx512_la_CFLAGS += \
> > -mavx512vl
> > lib_libopenvswitchavx512_la_SOURCES += \
> > lib/dpif-netdev-extract-avx512.c \
> > - lib/dpif-netdev-lookup-avx512-gather.c
> > + lib/dpif-netdev-lookup-avx512-gather.c \
> > + lib/odp-execute-avx512.c
> > endif # HAVE_AVX512VL
> > endif # HAVE_AVX512BW
>
> <snipped>
>
> Thanks and regards
> Sunil
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
