On Wed, Aug 03, 2022 at 12:32:46PM +0200, Vlad Buslov wrote: > Referenced commit changed policer action type from TC_ACT_UNSPEC (continue) > to TC_ACT_PIPE. However, since neither TC hardware offload layer nor mlx5 > driver at the time validated action type and always assumed 'continue', the > breakage wasn't caught until later validation code was added. The change > also broke valid configuration when sending from offload-capable device to > non-offload capable. For example, when sending from mlx5 VF to OvS bridge > netdevice the traffic that passed matchall classifier with policer could no > longer match the following flower rule in software:
... > Notes: > Changes V2 -> V3: > > - Refactored the fix to set action TC_ACT_UNSPEC only for matchall/basic > classifiers. > > Changes V1 -> V2: > > - Rebase on latest master. ... Hi Vlad, thanks for addressing our concerns. We have reviewed and tested this patch and do not observe any problems for our use-cases: in particular mirred after meter (police). Acked-by: Simon Horman <simon.hor...@corigine.com> I'd also be happy to apply this to the upstream tree if there are no objections from others. _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
