On Thu, Aug 04, 2022 at 09:59:24AM +0100, Simon Horman wrote:
> On Thu, Aug 04, 2022 at 10:24:52AM +0200, Ilya Maximets wrote:
> > On 8/4/22 09:52, Simon Horman wrote:
> > > On Thu, Aug 04, 2022 at 09:33:15AM +0200, Ilya Maximets wrote:
> > >> On 8/4/22 09:18, Simon Horman wrote:
...
> > >>> I'd also be happy to apply this to the upstream tree
> > >>> if there are no objections from others.
> > >>
> > >> No objections from my side.
> > >>
> > >> Regarding backports, AFAICT, we'll need that change down to 2.16, right?
> > >> Can code from v1 be used on 2.17 and 2.16 or do we need a separate
> > >> backport patch?
> > >
> > > I think that the complexity that v3 addresses arises from metering support
> > > which allows other actions to follow a police action (meter).
> > >
> > > So, assuming metering is not present in 2.17 and 2.16, and given that it
> > > turns out that UNSPEC is fine for both PPS and BPS, then I suspect we
> > > can go for a simple backport-patch which simply changes TC_ACT_PIPE
> > > to TC_ACT_UNSPEC in nl_msg_act_police_end_nest().
> > >
> > > This would need some testing, IMHO, and I may end up eating the words
> > > above.
> >
> > If that works, sounds good to me.
> >
> > Vlad, could you also test this approach with 2.17 ?
> >
> > I think, the best way forward will be to apply v3 to master and branch-3.0
> > now. Once the approach above for 2.17/2.16 is tested to work or some other
> > solution is chosen, one of you could post the backport patch, so it can be
> > reviewed/applied.
> >
> > What do you think?
>
> Yes, I agree we should move forwards on applying this to branch-3.0,
> and tackle 2.17/2.16 separately.
Patch pushed to.
1. main
d9268782af4d ("netdev-linux: set correct action for packets that passed
policer")
https://github.com/openvswitch/ovs/commit/d9268782af4d7fe8872393c98c22f39bfc124610
2. branch-3.0
5ce25c4b75c1 ("netdev-linux: set correct action for packets that passed
policer")
https://github.com/openvswitch/ovs/commit/5ce25c4b75c1d09e13ef8566c5f86728e2a4c5b1
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
