On 8/4/22 17:56, Dumitru Ceara wrote: > On 8/4/22 17:51, Ilya Maximets wrote: >> On 8/4/22 17:47, Dumitru Ceara wrote: >>> On 8/4/22 16:33, Mike Pattrick wrote: >>>> On Thu, Aug 4, 2022 at 9:56 AM Ilya Maximets <i.maxim...@ovn.org> wrote: >>>>> >>>>> With just released flake8 5.0 we're getting a bunch of E275 errors: >>>>> >>>>> utilities/bugtool/ovs-bugtool.in:959:23: E275 missing whitespace after >>>>> keyword >>>>> tests/test-ovsdb.py:623:11: E275 missing whitespace after keyword >>>>> python/setup.py:105:8: E275 missing whitespace after keyword >>>>> python/setup.py:106:8: E275 missing whitespace after keyword >>>>> make[2]: *** [flake8-check] Error 1 >>>>> >>>>> This breaks CI on branches below 2.16. We don't see a problem right >>>>> now on newer branches because we're installing extra dependencies >>>>> that backtrack flake8 down to 4.1 or even 3.9. >>>>> >>>>> Signed-off-by: Ilya Maximets <i.maxim...@ovn.org> >>>> >>>> Looks good to me! >>>> >>>> Acked-by: Mike Pattrick <m...@redhat.com> >>>> >>> >>> I'm still getting: >>> >>> python/ovs/db/idl.py:145:15: E275 missing whitespace after keyword >>> python/ovs/db/idl.py:167:15: E275 missing whitespace after keyword >>> >>> Because of "assert" being a keyword too. >> >> OK. I only fixed ones that failed CI on branch-2.15 and below >> and this code is fairly new. >> >> I can fold the following in while applying the change, If that's OK: >> >> diff --git a/python/ovs/db/idl.py b/python/ovs/db/idl.py >> index b87099ff5..8f13d1f55 100644 >> --- a/python/ovs/db/idl.py >> +++ b/python/ovs/db/idl.py >> @@ -142,7 +142,7 @@ class ConditionState(object): >> >> class IdlTable(object): >> def __init__(self, idl, table): >> - assert(isinstance(table, ovs.db.schema.TableSchema)) >> + assert isinstance(table, ovs.db.schema.TableSchema) >> self._table = table >> self.need_table = False >> self.rows = custom_index.IndexedRows(self) >> @@ -164,7 +164,7 @@ class IdlTable(object): >> >> @condition.setter >> def condition(self, condition): >> - assert(isinstance(condition, list)) >> + assert isinstance(condition, list) >> self.idl.cond_change(self.name, condition) >> >> @classmethod >> --- >> >> What do you think? > > Looks good to me, thanks! > > Acked-by: Dumitru Ceara <dce...@redhat.com> >
Thanks! Applied to all supported branches down to 2.13. Best regards, Ilya Maximets. _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
