Hi Sunil, Sure will put the intent in the Commit log.
> -----Original Message----- > From: Pai G, Sunil <sunil.pa...@intel.com> > Sent: Monday, October 3, 2022 8:56 PM > To: Amber, Kumar <kumar.am...@intel.com>; ovs-dev@openvswitch.org > Cc: i.maxim...@ovn.org; f...@sysclose.org; Amber, Kumar > <kumar.am...@intel.com> > Subject: RE: [ovs-dev] [PATCH v5 1/9] dpif-netdev: Refactor per thread recirc > data allocation. > > > > > -----Original Message----- > > From: dev <ovs-dev-boun...@openvswitch.org> On Behalf Of Kumar > Amber > > Sent: Friday, August 26, 2022 5:01 AM > > To: ovs-dev@openvswitch.org > > Cc: i.maxim...@ovn.org; f...@sysclose.org; Amber, Kumar > > <kumar.am...@intel.com> > > Subject: [ovs-dev] [PATCH v5 1/9] dpif-netdev: Refactor per thread > > recirc data allocation. > > > > The refactor allows us to use *recirc_depth_get() to obtain the depth > > across ovs which was previously limited to only dpif-netdev.c. > > > > Signed-off-by: Kumar Amber <kumar.am...@intel.com> > > Signed-off-by: Cian Ferriter <cian.ferri...@intel.com> > > Co-authored-by: Cian Ferriter <cian.ferri...@intel.com> > > Acked-by: Harry van Haaren <harry.van.haa...@intel.com> > > --- > > lib/dpif-netdev-private-dpif.c | 2 ++ lib/dpif-netdev-private-dpif.h > > | 5 +++++ > > lib/dpif-netdev.c | 3 --- > > 3 files changed, 7 insertions(+), 3 deletions(-) > > > > Hi Amber, > > I would prefer if you mentioned the intent behind this patch in the commit > message. [the cover letter doesn’t get applied]. > Example: This is a precursor to enabling ... > > Otherwise, the changes look good to me, I'm happy to ack. > > Acked-by: Sunil Pai G <sunil.pa...@intel.com> > > Thanks and regards > Sunil _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
