Hi Sunil, Sure will fix that comment.
Regards Amber > -----Original Message----- > From: Pai G, Sunil <sunil.pa...@intel.com> > Sent: Tuesday, October 4, 2022 3:21 PM > To: Amber, Kumar <kumar.am...@intel.com>; ovs-dev@openvswitch.org > Cc: i.maxim...@ovn.org; f...@sysclose.org; Amber, Kumar > <kumar.am...@intel.com> > Subject: RE: [ovs-dev] [PATCH v5 3/9] dpif-netdev-avx512: Refactor avx512 > dpif and create new APIs. > > Hi Amber, > > One minor nit inline. > > > diff --git a/lib/dpif-netdev-private-dpif.h b/lib/dpif-netdev-private- > > dpif.h index b3e75b7a2..46ce4ecf6 100644 > > --- a/lib/dpif-netdev-private-dpif.h > > +++ b/lib/dpif-netdev-private-dpif.h > > @@ -86,8 +86,16 @@ dp_netdev_input(struct dp_netdev_pmd_thread > *pmd, > > > > /* AVX512 enabled DPIF implementation function. */ int32_t - > > dp_netdev_input_outer_avx512(struct dp_netdev_pmd_thread *pmd, > > - struct dp_packet_batch *packets, > > - odp_port_t in_port); > > +dp_netdev_input_avx512(struct dp_netdev_pmd_thread *pmd, > > + struct dp_packet_batch *packets, > > + odp_port_t in_port); > > + > > +int32_t > > +dp_netdev_input_avx512_recirc(struct dp_netdev_pmd_thread *pmd, > > + struct dp_packet_batch *packets); > > + > > +int32_t > > +dp_netdev_recirculate(struct dp_netdev_pmd_thread *, > > + struct dp_packet_batch *); > > > > Nit: You might want to move this declaration of recirculate fn before the > comment: > "/* AVX512 enabled DPIF implementation function. */" > > Other than that, > Acked-by: Sunil Pai G <sunil.pa...@intel.com> > > Thanks and regards > Sunil _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
