Hi Ales,
May I suggest placing the tests that are failing with the userspace
datapath into the tests/system-ovn-kmod.at file? The current structure
of the test files is:
tests/system-ovn.at: Tests that can run with any datapath.
tests/system-ovn-kmod.at: Tests that can only be run with the kernel
datapath.
Presumably if there was ever a test that only passed with the userspace
datapath, we'd add a file for that too.
Note that you'll still want the new macro in this commit, since there's
nothing in the build system that ensures that tests in
tests/system-ovn-kmod.at are only run with the kernel datapath. The
separate files are strictly for organization.
On 2/21/23 07:32, Ales Musil wrote:
There is a bug in userspace datapath that causes
failures within the LB affinity test [0].
Skip the test until the bug is fixed.
[0] https://bugzilla.redhat.com/2170828
Signed-off-by: Ales Musil <amu...@redhat.com>
---
tests/system-kmod-macros.at | 6 ++++++
tests/system-ovn.at | 2 ++
tests/system-userspace-macros.at | 9 +++++++++
3 files changed, 17 insertions(+)
diff --git a/tests/system-kmod-macros.at b/tests/system-kmod-macros.at
index 787a59c97..e72a2970b 100644
--- a/tests/system-kmod-macros.at
+++ b/tests/system-kmod-macros.at
@@ -183,3 +183,9 @@ m4_define([OVS_CHECK_KERNEL_EXCL],
sublevel=$(uname -r | sed -e 's/\./ /g' | awk '{print $ 2}')
AT_SKIP_IF([ ! ( test $version -lt $1 || ( test $version -eq $1 && test $sublevel
-lt $2 ) || test $version -gt $3 || ( test $version -eq $3 && test $sublevel -gt $4 ) )
])
])
+
+# CHECK_USERSPACE_DATAPATH()
+#
+# Perform requirements checks for running with OvS userspace datapath.
+# Some tests are failing for userspace datapath.
+m4_define([CHECK_USERSPACE_DATAPATH])
diff --git a/tests/system-ovn.at b/tests/system-ovn.at
index f56e61923..cfa56ee48 100644
--- a/tests/system-ovn.at
+++ b/tests/system-ovn.at
@@ -8709,6 +8709,7 @@ AT_KEYWORDS([ovnlb])
CHECK_CONNTRACK()
CHECK_CONNTRACK_NAT()
+CHECK_USERSPACE_DATAPATH()
ovn_start
OVS_TRAFFIC_VSWITCHD_START()
ADD_BR([br-int])
@@ -9005,6 +9006,7 @@ AT_KEYWORDS([ovnlb])
CHECK_CONNTRACK()
CHECK_CONNTRACK_NAT()
+CHECK_USERSPACE_DATAPATH()
ovn_start
OVS_TRAFFIC_VSWITCHD_START()
ADD_BR([br-int])
diff --git a/tests/system-userspace-macros.at b/tests/system-userspace-macros.at
index 86ed22622..1dc682783 100644
--- a/tests/system-userspace-macros.at
+++ b/tests/system-userspace-macros.at
@@ -294,3 +294,12 @@ m4_define([OVS_CHECK_KERNEL_EXCL],
[
AT_SKIP_IF([:])
])
+
+# CHECK_USERSPACE_DATAPATH()
+#
+# Perform requirements checks for running with OvS userspace datapath.
+# Some tests are failing for userspace datapath.
+m4_define([CHECK_USERSPACE_DATAPATH],
+[
+ AT_SKIP_IF([:])
+])
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
