On Wed, Mar 01, 2023 at 07:31:04AM +0100, Ales Musil wrote: > On Tue, Feb 28, 2023 at 8:03 PM Mark Michelson <mmich...@redhat.com> wrote: > > > Hi Ales, > > > > > May I suggest placing the tests that are failing with the userspace > > datapath into the tests/system-ovn-kmod.at file? The current structure > > of the test files is: > > > > tests/system-ovn.at: Tests that can run with any datapath. > > tests/system-ovn-kmod.at: Tests that can only be run with the kernel > > datapath. > > > > Presumably if there was ever a test that only passed with the userspace > > datapath, we'd add a file for that too. > > > > Note that you'll still want the new macro in this commit, since there's > > nothing in the build system that ensures that tests in > > tests/system-ovn-kmod.at are only run with the kernel datapath. The > > separate files are strictly for organization. > > > > > Hi Mark, > > wouldn't that be a bit counter intuitive? The main goal is to have > everything working with userspace datapath, so if there is a fix > we would move the test back. > > Anyway I don't have a strong preference so if there is an agreement > I'll update this commit.
FWIIW, I think the distinction is between: 1. Expected to work, but does not. F.e. bug somewhere; and 2. Not expected to work. F.e. feature or behaviour exists in one datapath but not the other (yet). I haven't looked closely, so I'm unsure which category these tests fall into. _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
