On 7/11/23 17:08, Eelco Chaudron wrote: > > > On 11 Jul 2023, at 16:38, Ilya Maximets wrote: > >> On 7/11/23 12:17, Eelco Chaudron wrote: >>> >>> >>> On 13 Jun 2023, at 20:34, James Raphael Tiovalen wrote: >>> >>>> This commit adds non-null pointer assertions in some code that performs >>>> some decisions based on old and new input ovsdb_rows. >>>> >>>> Signed-off-by: James Raphael Tiovalen <jamestio...@gmail.com> >>>> Reviewed-by: Simon Horman <simon.hor...@corigine.com> >>> >>> What about error messages/argument checking instead of asserts here? >> >> File transactions must have some data. Every row must have at least >> uuid and version. New rows should have 'new' versions of the data, >> deleted should have 'old', and modified should have both. It's a >> bug somewhere if we have a row without any data. > > > Thanks for confirming/clarification. With this; > > Acked-by: Eelco Chaudron <echau...@redhat.com>
Thanks, James, Simon and Eelco! Applied this one. Best regards, Ilya Maximets. _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
