On Wed, Jul 12, 2023 at 6:49 AM Ilya Maximets <i.maxim...@ovn.org> wrote: > > These are not optional for a json parser and ovsdb_parser_finish() > checks and fails if they do not exist. I don't think we should > check them here. If we can't trust the parser code, we'll need to > add this kind of checks in many other places as well to be consistent. > I'd like not to do that. >
Sure, will remove them in the next patch version then. > > If the schema didn't exist, we would crash in the loop above. > Also the ovsdb_schema_create() can't fail, so we should not > need to check it. > Got it, will remove the check as well. > > Here it's also not clear why we're checking in this branch and not > in the other. If we're checking condition, why not checking the > table, for example. > Hmm okay, I will remove this check then. Best regards, James Raphael Tiovalen _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
