On 10/6/23 09:08, Dumitru Ceara wrote: > Hi Xavier, Mark, > > On 9/21/23 15:27, Xavier Simonart wrote: >> Hi Mark >> >> Thanks for the review. See comments below. >> Thanks >> Xavier >> >> >> On Tue, Sep 19, 2023 at 5:29 PM Mark Michelson <mmich...@redhat.com> wrote: >> >>> Thanks for the patch set Xavier. >>> >>> With the exception of patch 13: >>> >>> Acked-by: Mark Michelson <mmich...@redhat.com> >>> >>> I'm acking the patch set, but the nature of these changes worries me. I >>> could easily see another patch series like this needed in the future >>> because it's too easy to write flaky tests. Here are some high-level >>> ideas I have based on changes I see in these patches. >>> >>> +1 > > I'm planning to apply the patches that have no ongoing discussion, that > is: 1-3, 6-11, 13. >
In the end I also skipped patch 6 because of merge conflicts and 13 because there's an ongoing discussion: https://patchwork.ozlabs.org/project/ovn/patch/20230918164714.3144984-14-xsimo...@redhat.com/ I applied the other 8 patches to main and backported them where applicable. > For the rest I'll wait for the discussion to settle or for a v2. Some > more remarks inline. > > Thanks a lot for improving the tests, that's a very important aspect! > Regards, Dumitru _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
