Jakob Meng <[email protected]> writes: > On 25.10.23 11:59, 0-day Robot wrote: > >> Bleep bloop. Greetings Jakob Meng, I am a robot and I have tried out your >> patch. >> Thanks for your contribution. >> >> I encountered some error that I wasn't expecting. See the details below. >> >> >> checkpatch: >> WARNING: Line lacks whitespace around operator >> WARNING: Line lacks whitespace around operator >> #696 FILE: utilities/ovs-appctl.c:112: >> -f, --format=FMT Output format. One of: 'json', or 'text'\n\ >> >> Lines checked: 842, Warnings: 2, Errors: 0 >> >> >> Please check this out. If you feel there has been an error, please email >> [email protected] >> > Shall we fix utilities/checkpatch.py or simply ignore this message?
Ideally both - since we should be able to catch that we're in a string in many instances. That said, it gets a bit more complicated in practice because inserting without a leading '"' or trailing '"' means we don't have the context (unless we do something like apply the patch and then scan the lines keeping the context). We usually these kinds of errors since they are obviously tool limitations. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
