On Tue, Feb 13, 2024 at 08:40:18PM +0100, Ilya Maximets wrote: > OpenSSL 1.0.2u is long deprecated and not available for download. > So, our CI never actually downloads it and uses whatever is in the > OpenSSL-Win64 folder provided by AppVeyor. Luckily, it happens to > be OpenSSL 1.0.2u today. > > The oldest supported version of OpenSSL upstream today is 3.0. > And it is an LTS version. 3.1 and 3.2 are not LTS. > > Use OpenSSL 3.0 for testing instead. > > This commit does a few things to achieve that: > > 1. Removes the folder provided by AppVeyor. This way we will fail > the build if something goes wrong instead of silently using > OpenSSL version provided by AppVeyor. > > 2. Obtains the JSON description of available releases and downloads > the latest minor version of OpenSSL 3.0 64-bit. With this approach > we should not need to update the download link that frequently. > New minor releases will be picked up automatically. They should > not have any breaking changes, so should be fine to use in CI. > OpenSSL 3.0 is supported until at least Sep 2026. > > The JSON file is an official file referenced on the: > https://slproweb.com/products/Win32OpenSSL.html > So, it should be safe to use. > > 3. Executes the downloaded installer with 'Start-Process -Wait' to > properly wait for installation to finish instead of just sleeping > for 30 seconds. > > 4. Caches the downloaded installer, so we're not downloading 300 MB > on each CI run as that is not nice to do. We know the hash of the > latest version, so we will re-download only when the binary changes, > i.e. on a new minor release. > > For the cache to work we need to introduce the 'install' phase, > because caches are populated after 'init', but before 'install'. > Alternatively, we could have just renamed 'init' to 'install', > but I think it's a little nicer to have separate phases, and we > can also move 'windows-prepare.sh' to the install phase. > > Cache is also invalidated whenever appveyor.yml changes. > > Signed-off-by: Ilya Maximets <i.maxim...@ovn.org>
Acked-by: Simon Horman <ho...@ovn.org> _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
