Thank you so much for the patches and dealing with this, Ilya! Regarding the MD / MT linking for a given binary, this can work, usually, without any issues, although it will increase the memory used by the process because both runtimes have to be loaded.
We are linking the rest of the binaries with MT / MTd inside OVS: https://github.com/openvswitch/ovs/blob/master/build-aux/cccl#L92-L98 . Can you please change the OpenSSL to link with MT instead of MD? This will ensure that we test with what will be built in the end. Because we are changing the defaults to msys2 / openssl3 we need to also update the documentation. I'm okay with changing it to a later date. If you prefer, I can pick this one up. I will insert the snippets where the documentation has to be changed for OpenSSL: https://github.com/openvswitch/ovs/blob/master/Documentation/intro/install/windows.rst?plain=1#L109-L115 https://github.com/openvswitch/ovs/blob/master/Documentation/intro/install/windows.rst?plain=1#L179-L185 https://github.com/openvswitch/ovs/blob/master/Documentation/intro/install/windows.rst?plain=1#L191-L199 Alin. ________________________________ From: dev <ovs-dev-boun...@openvswitch.org> on behalf of Simon Horman <ho...@ovn.org> Sent: Thursday, February 15, 2024 2:08 PM To: Ilya Maximets <i.maxim...@ovn.org> Cc: ovs-dev@openvswitch.org <ovs-dev@openvswitch.org> Subject: Re: [ovs-dev] [PATCH 3/4] m4: Fix linking with OpenSSL 1.1.0+ and 3+ on Windows. On Tue, Feb 13, 2024 at 08:40:17PM +0100, Ilya Maximets wrote: > OpenSSL 1.1.0 changed the library names from libeay32 and ssleay32 to > standard libssl and libcrypto. All the versions of OpenSSL that used > old names reached their official EoL, so it should be safe to just > migrate to new names. They can still be supported via premium support > option, but I don't think that is important for us. > > Also, OpenSSL installers for older versions had the following folder > structure: ... > Basically, instead of one generic library in the lib folder and a bunch > of differently named versions of it for different type of linkage, we > now have multiple instances of the library located in different folders > based on the linkage type. So, we have to provide an exact path in > order to find the library. > > 'lib/VC/x64/MD' was chosen in this patch and it seems to work fine. > MD stands for dynamic linking, MT is static, 'd' stands for debug > versions of the libraries. > > Signed-off-by: Ilya Maximets <i.maxim...@ovn.org> Acked-by: Simon Horman <ho...@ovn.org> ... _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
