sendpkt.py is used in system tests to send raw packets to interfaces.
It is fed with plain hex bytes that are hard to read and understand.

This patch set teaches sendpkt to accept hex strings in slightly
different formats and teaches compose-packet command to generate NSH
headers.  With that most of the sendpkt.py calls updated to consume
packets generated from OpenFlow descriptions instead of plain coding
the bytes and checking code updated to compare results against these
composed packets.

Suggestion is to get these changes to all supported branches and
start writing new tests in the same way.  This patch set does add
some new functionality, but it is test-only, so should be OK to
backport.

There are still a few plain hex calls to sendpkt.py.  One is a
intentionally malformed geneve packet that we can't generate (at least
not fully), the others are IGMP packets that OVS doesn't fully parse
and doesn't have a way to represent fully in OpenFlow.

Next step might be to replace some of the packet-out calls as well.

Ilya Maximets (3):
  tests: sendpkt: Allow different input formats.
  tests: Convert ND, MPLS and CT sendpkt tests to compose-packet.
  nsh: Add support to compose-packet and use it in system tests.

 lib/flow.c              |  18 ++
 tests/sendpkt.py        |  26 +--
 tests/system-traffic.at | 412 ++++++++++++++++++++++++++--------------
 3 files changed, 291 insertions(+), 165 deletions(-)

-- 
2.45.0

_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to