On 6/3/24 17:09, Simon Horman wrote: > On Fri, May 31, 2024 at 11:45:12PM +0200, Ilya Maximets wrote: >> OVS can parse NSH, but can't compose. Fix that and get rid of plain >> hex NSH packets in system tests as they are hard to read or modify. >> >> Tcpdump calls modified to write actual pcaps instead of text output, >> so ovs-pcap can be used while checking the results. >> >> While at it, replacing sleeps with more robust waiting for tcpdump >> to start listening. > > I might have separated a) adding NSH compose support
The tests in the patch provide some test coverage for this as well, so I didn't want to split for that reason. > b) more robust tcpdump waiting, We still need to change '>' to '-w' in very same lines, so I though it's better to not touch the same code twice and just combine the change, since it's fairly minor. > and c) using text rather than hex, > into 3 patches. But I don't feel strongly about it. For now, I kept the patches as they are for reasons stated above. Mostly to avoid touching the same code multiple times. > >> M4 macros are better than shell variables, because we can see the >> substitution result in the test log. So, using m4_define and m4_join >> extensively. >> >> Signed-off-by: Ilya Maximets <i.maxim...@ovn.org> > > Acked-by: Simon Horman <ho...@ovn.org> > Thanks, Simon and Eelco! I applied the set and backported to all branches, so we can backport tests for future fixes without trouble of re-working them for each branch. Best regards, Ilya Maximets. _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
