On 6/24/24 20:00, Adrián Moreno wrote: > On Mon, Jun 24, 2024 at 02:03:00PM GMT, Ilya Maximets wrote: > [...] >> >> Why are we adding IPFIX? This should work without IPFIX. >> >> Having both together can be a separate test. >> >>> + >>> +AT_DATA([flows.txt], [dnl >>> +in_port=ovs-p0,ip >>> actions=sample(probability=65535,collector_set_id=1,obs_domain_id=1431655765,obs_point_id=1717986918),output(port=ovs-p1,max_len=100) >>> +in_port=ovs-p1,ip >>> actions=sample(probability=65535,collector_set_id=2,obs_domain_id=2290649224,obs_point_id=2576980377),output(port=ovs-p0,max_len=100) >> >> It should be possible to wrap these lines a little with dnl. > > I'm curious about wrapping requirements for flows in tests. > None of them seem to be wrapped, splitting matches and actions won't > make lines much shorter and having more exotic wrapped & indented > action arguments seem strage to read (for eyes made to read flows in > a single line). What wrapping do you have in mind?
No hard requirements, but I find lines that long hard to read since they are going out of the window width for me and getting wrapped in random places. AT_DATA([flows.txt], [dnl in_port=ovs-p0,ip dnl actions=dnl sample( dnl probability=65535, dnl collector_set_id=1, dnl obs_domain_id=1431655765, dnl obs_point_id=1717986918), dnl output(port=ovs-p1,max_len=100) ... I agree that above is not very readable... Or AT_DATA([flows.txt], [dnl m4_join([], [ [in_port=ovs-p0,ip], [ ], [actions=], [sample(probability=65535,collector_set_id=1,obs_domain_id=1431655765,obs_point_id=1717986918)], [output(port=ovs-p1,max_len=100)] ] m4_join([], [ [in_port=ovs-p1,ip], [ ], [actions=], [sample(probability=65535,collector_set_id=2,obs_domain_id=2290649224,obs_point_id=2576980377)], [output(port=ovs-p0,max_len=100)] ] ) Or maybe just shorten the lines with a macro: m4_define([SAMPLE_ACTION], [sample(probability=65535,collector_set_id=$1,obs_domain_id=$2,obs_point_id=$3)] ) AT_DATA([flows.txt], [dnl in_port=ovs-p0,ip actions=SAMPLE_ACTION(1, 1431655765, 1717986918), output(port=ovs-p1,max_len=100) in_port=ovs-p1,ip actions=SAMPLE_ACTION(2, 2290649224, 2576980377), output(port=ovs-p0,max_len=100) ]) (Haven't tested any of these) Best regards, Ilya Maximets. _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
