On 1/16/25 12:31 PM, Dumitru Ceara wrote:
>>> +
>>> +struct advertise_datapath_entry {
>>> + struct hmap_node node;
>>> + /* tunnel_key of the datapath */
>>> + int64_t key;
>
> Do we need the key? It's part of the 'db' sbrec_datapath_binding field
> below.
>
>>> + const struct sbrec_datapath_binding *db;
>>> + bool maintain_vrf;
>>> + bool use_netns;
>>> + struct hmap routes;
Also, I forgot to mention this nit:
s/the name/The name/
And please add a newline here.
>>> + /* the name of the port bindings locally bound for this datapath and
>>> + * running route exchange logic. */
>>> + struct sset bound_ports;
>>> +};
>
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
