On Thu, Jan 16, 2025 at 12:32:30PM +0100, Dumitru Ceara wrote:
> On 1/16/25 12:31 PM, Dumitru Ceara wrote:
> >>> +
> >>> +struct advertise_datapath_entry {
> >>> + struct hmap_node node;
> >>> + /* tunnel_key of the datapath */
> >>> + int64_t key;
> >
> > Do we need the key? It's part of the 'db' sbrec_datapath_binding field
> > below.
> >
> >>> + const struct sbrec_datapath_binding *db;
> >>> + bool maintain_vrf;
> >>> + bool use_netns;
> >>> + struct hmap routes;
>
> Also, I forgot to mention this nit:
>
> s/the name/The name/
>
> And please add a newline here.
Hi Dumitru,
thanks for the review. All of these will be addressed in the next
version.
Thanks a lot
Felix
>
> >>> + /* the name of the port bindings locally bound for this datapath and
> >>> + * running route exchange logic. */
> >>> + struct sset bound_ports;
> >>> +};
> >
>
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
