On 1/29/25 12:16 PM, Felix Huettner via dev wrote:
> Previously vrf names where generated using "ovnvrf" + datapath id.
> Now the controller supports the dynamic-routing-vrf-name setting to
> overwrite this to whatever value the user desires.
> Note that the vrf ID is still the datapath id.
>
> Signed-off-by: Felix Huettner <[email protected]>
> ---
Hi Felix,
Again, not a full review, just a comment after debugging the test failure.
> diff --git a/tests/system-ovn.at b/tests/system-ovn.at
> index 963a67e0c..12985edd2 100644
> --- a/tests/system-ovn.at
> +++ b/tests/system-ovn.at
> @@ -14867,6 +14867,7 @@ OVN_FOR_EACH_NORTHD([
> AT_SETUP([dynamic-routing - DGP])
>
> VRF_RESERVE([1337])
> +VRF_RESERVE([1338])
>
> # This test uses dynamic routing on a simulated multi-tenant internet
> # connection.
> @@ -15113,10 +15114,22 @@ blackhole 192.0.2.10 proto 84 metric 100
> blackhole 198.51.100.0/24 proto 84 metric 1000
> 233.252.0.0/24 via 192.168.10.10 dev lo onlink])
>
> +# Changing the vrf name will switch to the new one.
> +check ovn-nbctl --wait=hv set Logical_Router internet
> options:dynamic-routing-vrf-name=ovnvrf1338
> +check ovn-nbctl --wait=hv set Logical_Router_Port internet-phys \
> + options:dynamic-routing-maintain-vrf=true
> +OVS_WAIT_UNTIL_EQUAL([ip route list vrf ovnvrf1338 | awk '{$1=$1};1'], [dnl
This fails on my setup and in GitHub CI:
system-ovn.at:15469: waiting until ip route list vrf ovnvrf1338 | awk
'{$1=$1};1' | diff -u wait_until_expected - ...
Error: argument "ovnvrf1338" is wrong: Invalid VRF
Probably because the latest northd v4 series is expecting
dynamic-routing-vrf-name to be configured on a port and this
ovn-controller v5 series sets it on the router.
Maybe we should indeed merge these two series into a single one that
includes all components at this point (as v6). The northd part seems
almost ready to me.
I plan to finish reviewing the ovn-controller side of things early on
Monday.
> +blackhole 192.0.2.1 proto 84 metric 1000
> +blackhole 192.0.2.2 proto 84 metric 100
> +blackhole 192.0.2.3 proto 84 metric 100
> +blackhole 192.0.2.10 proto 84 metric 100
> +blackhole 198.51.100.0/24 proto 84 metric 1000
> +233.252.0.0/24 via 192.168.10.10 dev lo onlink])
> +
> # Stoping with --restart will not touch the routes.
> check ovn-appctl -t ovn-controller exit --restart
> OVS_WAIT_UNTIL([test "$(ovn-appctl -t ovn-controller debug/status)" !=
> "running"])
> -OVS_WAIT_UNTIL_EQUAL([ip route list vrf ovnvrf1337 | awk '{$1=$1};1'], [dnl
> +OVS_WAIT_UNTIL_EQUAL([ip route list vrf ovnvrf1338 | awk '{$1=$1};1'], [dnl
> blackhole 192.0.2.1 proto 84 metric 1000
> blackhole 192.0.2.2 proto 84 metric 100
> blackhole 192.0.2.3 proto 84 metric 100
Regards,
Dumitru
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
