Originally reported by coverity:
*** CID 490929: Control flow issues (DEADCODE)
/utilities/ovn-ic-nbctl.c: 664 in ic_nbctl_trp_del()
658 free(tr_uuid);
659 if (ctx->error) {
660 return;
661 }
662
663 if (!trp) {
>>> CID 490929: Control flow issues (DEADCODE)
>>> Execution cannot reach this statement: "return;".
664 return;
665 }
666
667 icnbrec_transit_router_update_ports_delvalue(tr, trp);
668 icnbrec_transit_router_port_delete(trp);
669 }
** CID 490928: Error handling issues (CHECKED_RETURN)
/utilities/ovn-ic-nbctl.c: 739 in ic_nbctl_trp_add()
Fixes: 89eb631d5de6 ("ic: Add Transit router support.")
Signed-off-by: Ales Musil <[email protected]>
---
utilities/ovn-ic-nbctl.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/utilities/ovn-ic-nbctl.c b/utilities/ovn-ic-nbctl.c
index 94d63bd2f..50e975283 100644
--- a/utilities/ovn-ic-nbctl.c
+++ b/utilities/ovn-ic-nbctl.c
@@ -660,10 +660,6 @@ ic_nbctl_trp_del(struct ctl_context *ctx)
return;
}
- if (!trp) {
- return;
- }
-
icnbrec_transit_router_update_ports_delvalue(tr, trp);
icnbrec_transit_router_port_delete(trp);
}
--
2.51.0
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
