On Mon, Oct 27, 2025 at 1:06 PM Dumitru Ceara <[email protected]> wrote:
> On 10/24/25 10:19 AM, Ales Musil via dev wrote:
> > Originally reported by coverity:
> >
> > *** CID 490929: Control flow issues (DEADCODE)
> > /utilities/ovn-ic-nbctl.c: 664 in ic_nbctl_trp_del()
> > 658 free(tr_uuid);
> > 659 if (ctx->error) {
> > 660 return;
> > 661 }
> > 662
> > 663 if (!trp) {
> >>>> CID 490929: Control flow issues (DEADCODE)
> >>>> Execution cannot reach this statement: "return;".
> > 664 return;
> > 665 }
> > 666
> > 667 icnbrec_transit_router_update_ports_delvalue(tr, trp);
> > 668 icnbrec_transit_router_port_delete(trp);
> > 669 }
> >
> > ** CID 490928: Error handling issues (CHECKED_RETURN)
> > /utilities/ovn-ic-nbctl.c: 739 in ic_nbctl_trp_add()
> >
> > Fixes: 89eb631d5de6 ("ic: Add Transit router support.")
> > Signed-off-by: Ales Musil <[email protected]>
> > ---
>
> Hi Ales,
>
> Thanks for the patch, looks good to me!
>
> Acked-by: Dumitru Ceara <[email protected]>
>
> Regards,
> Dumitru
>
>
Thank you Dumitru,
I went ahead and merged this into main.
Regards,
Ales
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
