On 24 Sep 2025, at 10:45, Ratheesh Kannoth wrote:
>> From: Ratheesh Kannoth
>>> From: Eelco Chaudron <mailto:[email protected]>
>>
>>> The revalidator threads do not query individual flows; they will use the
>>> dump
>> APIs, so for tc, they will be the netdev_tc_flow_dump_XXX() functions.
>>
>> Offloaded interfaces are eth0 and sdp1-0 and its stats are incremented at HW
>> level (no driver involved), but flow_dump_create() request is for br0.
>> Marvell offload driver code is not updating br0 stats (br0 rx and tx are 0).
>>
>> So, driver code should update br0 stats (rx and tx) ?
>>
>> // below prints are generated by debug prints added by me
>>
>> Sep 24 02:28:43 localhost.localdomain ovs-vswitchd[408]:
>> ovs|00014|netdev_offload_tc(handler33)|ERR|netdev_tc_flow_put:2338
>> add rule eth0 Sep 24 02:28:43 localhost.localdomain ovs-vswitchd[408]:
>> ovs|00009|netdev_offload_tc(handler32)|ERR|netdev_tc_flow_put:2338
>> add rule sdp1-0 Sep 24 02:28:43 localhost.localdomain ovs-vswitchd[408]:
>> ovs|00039|netdev_offload_tc(revalidator35)|ERR|Dropped 15 log messages
>> in last 1 seconds (most recently, 0 seconds ago) due to excessive rate Sep 24
>> 02:28:43 localhost.localdomain ovs-vswitchd[408]:
>> ovs|00040|netdev_offload_tc(revalidator35)|ERR|netdev_tc_flow_dump_cr
>> eate:607 called for br0 Sep 24 02:28:44 localhost.localdomain ovs-
>> vswitchd[408]: ovs|00041|netdev_offload_tc(revalidator35)|ERR|Dropped
>> 15 log messages in last 1 seconds (most recently, 0 seconds ago) due to
>> excessive rate Sep 24 02:28:44 localhost.localdomain ovs-vswitchd[408]:
>> ovs|00042|netdev_offload_tc(revalidator35)|ERR|netdev_tc_flow_dump_cr
>> eate:607 called for br0
> There was some bug in our code. Now stats are syncing. Thanks a ton for your
> help. Really appreciate all the pointers/clues.
My pleasure! Are you guys joining the OVS Conference!? If accepted, I will be
presenting my proposed hardware offload infrastructure changes.
See my 40 patch RFC series :)
//Eelco
_______________________________________________
discuss mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-discuss
