Reviewing tha last commits I read a comment on the clean target in Makefile.am

> commit ce7d5e6ed7e4a033b5e59c681e0dcd7382ba6727
> Author: Johan Str<C3><B6>m <jo...@stromnet.se>
> Date:   Thu Mar 24 15:39:38 2016 +0100
> 
>     clean target: do not try to remove my home dir please (*~)
>     
>     rm -f wont delete my directory, but should probalby not be there anyway..
> 

According to the GNU Coding Standards, 
http://www.gnu.org/prep/standards/html_node/Standard-Targets.html#Standard-Targets
 
'make clean’ should remove only file created by 'make all’. All those 

@RM@ -f *.o *.tmp *.cpp .*~ stamp-* lint_cmac.h

remove backup files created by the editor, or files created by programs not 
under make control. See also the automake heuristics 
https://www.gnu.org/software/automake/manual/html_node/Clean.html
https://www.gnu.org/software/automake/manual/html_node/Standard-Targets.html

IMHO it is time to start uncluttering configure.ac and Makefile.am from 
unnecessary local additions (which may have become obsolete in the meantime, or 
even dangerous.) The same holds true for .gitignore: here we should list only 
build related files. (Local generated files not linked to the build system, 
like editor backups, should go in .git/info/exclude )

S.

> On 24 Mar 2016, at 16:12, Johan Ström <jo...@stromnet.se> wrote:
> 
> Hi,
> 
> I just commited a very first unit-test, something which the codebase is
> lacking today.
> Also merged the fix for FS_input_ascii_array, and some other cleanups.
> 
> The test is built with libcheck, a pretty simple C unittest library.
> It is by no means a decision on a lib to use, but it's a start.
> 
> To build, ensure libcheck is installed, re-run configure, and then make
> all check.
> 
> For the moment there is only a single test case, for
> FS_input_ascii_array (which was fixed through with help from this test).
> owfs (and C in generall) is a kindof tricky to write tests for, but it
> is doable.. at least for some parts..
> 
> Of course, this just tests an extremely small portion of the owfs
> codebase, but in the future we can add more, especially when debugging
> errors.
> 
> Johan
> 
> ------------------------------------------------------------------------------
> Transform Data into Opportunity.
> Accelerate data analysis in your applications with
> Intel Data Analytics Acceleration Library.
> Click to learn more.
> http://pubads.g.doubleclick.net/gampad/clk?id=278785351&iu=/4140
> _______________________________________________
> Owfs-developers mailing list
> Owfs-developers@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/owfs-developers

------------------------------------------------------------------------------
Transform Data into Opportunity.
Accelerate data analysis in your applications with
Intel Data Analytics Acceleration Library.
Click to learn more.
http://pubads.g.doubleclick.net/gampad/clk?id=278785351&iu=/4140
_______________________________________________
Owfs-developers mailing list
Owfs-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/owfs-developers

Reply via email to