Hi Jan,
thank you for the Answer and the description!
I've never made this procedure.
I've try this steps, but where should I send the email to?
the output looks like this:
owserver hangs some minutes when sequence number run over 0xFFFF
$ git format-patch master --stdout
c14b0e446e686b4ab158bad2d6b4ac111df14c8f..79382f3e10c6566ae2e189fb708dade77e077fd2
From 79382f3e10c6566ae2e189fb708dade77e077fd2 Mon Sep 17 00:00:00 2001
From: Enrico Hoepfner <enrico.hoepf...@gmx.de>
Date: Thu, 17 Nov 2016 17:39:29 +0100
Subject: [PATCH] fix sequence number bug in w1 host adaptor code
---
module/owlib/src/c/ow_w1_parse.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/module/owlib/src/c/ow_w1_parse.c
b/module/owlib/src/c/ow_w1_parse.c
index 3fd2e8f..611d3dc 100644
--- a/module/owlib/src/c/ow_w1_parse.c
+++ b/module/owlib/src/c/ow_w1_parse.c
@@ -232,7 +232,7 @@ enum Netlink_Read_Status W1_Process_Response( void
(* nrs_callback)( struct netl
// Don't need to free since nlm not set if BAD
return nrs_error ;
}
- if ( NL_SEQ(nlp.nlm->nlmsg_seq) != (unsigned int) seq ) {
+ if ( NL_SEQ(nlp.nlm->nlmsg_seq) != NL_SEQ(seq) ) {
LEVEL_DEBUG("Netlink sequence number out of
order");
owfree(nlp.nlm) ;
continue ;
--
1.9.1
$
Signed-off: "Enrico Hoepfner <enrico.hoepf...@gmx.de"
On 17.11.2016 11:21, Jan Kandziora wrote:
> Am 17.11.2016 um 07:13 schrieb Enrico Hoepfner:
>> the patch below works perfectly! thank you all for your help!
>>
>> how can I commit this patch to owfs source? can this do someone of
>> the developers or is there a description how I can do that?
>>
> Install git and gitk.
>
> Setup git:
>
> $ git config --global user.name "Enrico Hoepfner"
> $ git config --global user.email "enrico.hoepf...@gmx.de"
>
> Clone the owfs git repository from sf.net (or github, that's a mirror):
> Use gitk to get an overview about commits.
>
> $ git clone https://github.com/owfs/owfs.git
> $ cd owfs
> $ gitk&
>
> (later: pull the newest version with "git pull" instead)
>
> Bootstrap the repository to prepare it for your test compiles:
>
> $ ./bootstrap
> $ ./configure
>
> *** Apply your patches ***
>
> Do a test.
>
> $ make
> $ sudo make install
>
> Commit your patches:
>
> $ git commit -m "fix sequence number bug in w1 host adaptor code"
> modules/owlib/...
>
> Export your patch in a format suitable for inclusion into the archive:
>
> $ git format-patch master --stdout <old_id>..<new_id>
>
> <old_id> and <new_id> are the SHA1 ids as shown by the git tools, e.g. gitk&
>
> Paste that patch into an email (not as an attachment, just a plain pasting).
> Give further explanations on the "why" *in front* of it, and end with a line
>
> Signed-off: "Enrico Hoepfner <enrico.hoepf...@gmx.de"
>
> Make the email subject read "[PATCH 1/1]: fix sequence number bug in w1 host
> adaptor code"
>
> That's the procedure as used by the Linux kernel maintainers. We have far less
> patches than them so we can accept stray patches too, but adapting their
> procedure
> sure helps you to get patches accepted everywhere. It's just good practice.
>
>
> Kind regards
>
> Jan
>
> ------------------------------------------------------------------------------
> _______________________________________________
> Owfs-developers mailing list
> Owfs-developers@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/owfs-developers
------------------------------------------------------------------------------
_______________________________________________
Owfs-developers mailing list
Owfs-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/owfs-developers
