elek commented on a change in pull request #323: HDDS-2686. Use protobuf 3 instead of protobuf 2 URL: https://github.com/apache/hadoop-ozone/pull/323#discussion_r355366528
########## File path: pom.xml ########## @@ -149,7 +149,7 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xs <!-- ProtocolBuffer version, used to verify the protoc version and --> <!-- define the protobuf JAR version --> - <protobuf.version>2.5.0</protobuf.version> + <protobuf.version>3.10.0</protobuf.version> Review comment: In #300 `protobuf-compile.version` has been disappeared and we have only `datanode.protobuf-compile.version`. I reorganized this setting to be more similar: ``` <!-- Maven protoc compiler --> <protobuf-maven-plugin.version>0.5.1</protobuf-maven-plugin.version> <hadooprpc.protobuf-compile.version>3.10.0</hadooprpc.protobuf-compile.version> <datanode.protobuf-compile.version>3.10.0</datanode.protobuf-compile.version> ``` But let me know if you have any better idea... ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org
