elek commented on a change in pull request #323: HDDS-2686. Use protobuf 3 instead of protobuf 2 URL: https://github.com/apache/hadoop-ozone/pull/323#discussion_r355357064
########## File path: hadoop-hdds/common/src/main/proto/SCMSecurityProtocol.proto ########## @@ -21,6 +21,7 @@ * Please see http://wiki.apache.org/hadoop/Compatibility * for what changes are allowed for a *unstable* .proto interface. */ +syntax = "proto2"; Review comment: Agree. proto3 syntax is different. Easier to upgrade the compilation library first and update the proto files to syntax 3 in the next step. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org
