mukul1987 commented on a change in pull request #507: HDDS-2936. Hive queries
fail at readFully
URL: https://github.com/apache/hadoop-ozone/pull/507#discussion_r372931058
##########
File path:
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/io/KeyOutputStream.java
##########
@@ -201,7 +209,11 @@ private void handleWrite(byte[] b, int off, long len,
boolean retry)
// comes via Exception path.
int writeLen = Math.min((int) len, (int) current.getRemaining());
long currentPos = current.getWrittenDataLength();
- writeToOutputStream(current, retry, len, b, writeLen, off, currentPos);
+ // writeLen will be updated based on whether the write was succeeded
+ // or if it sees an exception, how much the actual write was
+ // acknowledged.
+ writeLen = writeToOutputStream(current, retry, len, b, writeLen,
Review comment:
writeLen, goes in both as an agrument as well as a return value to the
function. Can we change this to something like expectedWritelen, and writtenLen
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org
