fapifta commented on a change in pull request #507: HDDS-2936. Hive queries
fail at readFully
URL: https://github.com/apache/hadoop-ozone/pull/507#discussion_r372995510
##########
File path:
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/io/KeyOutputStream.java
##########
@@ -484,6 +499,9 @@ public void close() throws IOException {
closed = true;
try {
handleFlushOrClose(StreamAction.CLOSE);
+ if (!isException) {
+ Preconditions.checkArgument(writeOffset == offset);
Review comment:
At this point in the code I am not the fan of throwing an
IllegalArgumentException, wouldn't it be better to keep this as an IOException
with a specific explaining message?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org
