swagle commented on a change in pull request #839: HDDS-3411. Switch Recon SQL
DB to Derby.
URL: https://github.com/apache/hadoop-ozone/pull/839#discussion_r409982227
##########
File path:
hadoop-ozone/recon-codegen/src/main/java/org/hadoop/ozone/recon/codegen/JooqCodeGenerator.java
##########
@@ -55,10 +60,11 @@
private static final Logger LOG =
LoggerFactory.getLogger(JooqCodeGenerator.class);
- private static final String SQLITE_DB =
- System.getProperty("java.io.tmpdir") + "/recon-generated-schema";
- private static final String JDBC_URL = "jdbc:sqlite:" + SQLITE_DB;
-
+ private static final String DB = Paths.get(
+ System.getProperty("java.io.tmpdir"),
+ "recon-generated-schema-" + Time.monotonicNow()).toString();
Review comment:
Any reason to use a timestamp-based path?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org
