swagle commented on a change in pull request #839: HDDS-3411. Switch Recon SQL
DB to Derby.
URL: https://github.com/apache/hadoop-ozone/pull/839#discussion_r409983094
##########
File path:
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/persistence/DefaultDataSourceProvider.java
##########
@@ -43,14 +52,26 @@
*/
@Override
public DataSource get() {
Review comment:
This is actually an antipattern :-) Although I am guilty of this as well.
Instead of the if were should have a DerbyDataSourceProvider,
SqliteDataSourceProvider and Default one. Can be left as a TODO for later as
well, upto you.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org
