bharatviswa504 commented on a change in pull request #1169:
URL: https://github.com/apache/hadoop-ozone/pull/1169#discussion_r451940527
##########
File path: hadoop-ozone/interface-client/src/main/proto/OmClientProtocol.proto
##########
@@ -867,10 +867,10 @@ message DeletedKeys {
}
message DeleteKeysResponse {
- repeated KeyInfo deletedKeys = 1;
- repeated KeyInfo unDeletedKeys = 2;
Review comment:
The current behavior is we fail the entire batch if we are not able to
delete the key.
So, proposal is to change this behavior?
And also I see we fail to delete only when key not found. In this case,
there is no real point in returning them as unDeletedKeys. Not sure, even in
this case if it is helpful.
2nd case we fail is when checking ACLS, when user does not have permission,
in this case even if we return unDeletedKeys, not sure how it will be used.
3rd case, when reading DB failure, then also whole batch will be failed. As
anyway, at that time OM will be terminated, as this is a critical error to
avoid DB divergence.
So, still, I am not really sure what is real use case of returning
unDeletedKeys and how that will be used. Just trying to understand it.
The current PR, kept the behavior of existing behavior,(but only removed
return of unDeletedKeys) where it used to fail the entire batch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org
