xiaoyuyao commented on a change in pull request #1169:
URL: https://github.com/apache/hadoop-ozone/pull/1169#discussion_r452474846
##########
File path: hadoop-ozone/interface-client/src/main/proto/OmClientProtocol.proto
##########
@@ -867,10 +867,10 @@ message DeletedKeys {
}
message DeleteKeysResponse {
- repeated KeyInfo deletedKeys = 1;
- repeated KeyInfo unDeletedKeys = 2;
Review comment:
bq. The current behavior is we fail the entire batch if we are not able
to delete the key. So, proposal is to change this behavior?
The goal is to not fail the whole deletion when something failed in the
middle and return the list of deleted and undeleted to the client. We can't get
there if delete and undelete list are removed from the proto. Here is the
reason for keeping them for HDDS-3916.
1. It can be expensive to lookup or retry the whole list again if one of the
deletion failed.
2. Returning undelete file list reduce the amount of unnecessary processing.
Also holding the bucket lock once for all may not be a good idea to large
delete as that will prevent other clients operation on the same bucket. grab
and release individual or in small batches give other clients opportunities to
access buckets.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org
