sodonnel commented on pull request #1339: URL: https://github.com/apache/hadoop-ozone/pull/1339#issuecomment-678312913
> Basically AbstractContainerReportHandler is not the perfect place to handle this because it doesn't have a global view while Replication Manager has. ContainerReportHandler has the same view of all replicas as replication manager, as it has access to the ContainerManager object. I will push a new commit that adjusts the values based on all 3 replicas. I still need to add a test or two for this, but this demonstrates the point hopefully. Ideally, we should be updating these values in a single place. The containerReportHandler is supposed to do it, but it is not doing it correctly, so we need to fix that, rather than adding new logic elsewhere to work around the bug. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org
