adoroszlai commented on a change in pull request #1339:
URL: https://github.com/apache/hadoop-ozone/pull/1339#discussion_r475523841
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/AbstractContainerReportHandler.java
##########
@@ -103,13 +108,44 @@ private void updateContainerStats(final ContainerID
containerId,
containerInfo.updateSequenceId(
replicaProto.getBlockCommitSequenceId());
}
- if (containerInfo.getUsedBytes() != replicaProto.getUsed()) {
- containerInfo.setUsedBytes(replicaProto.getUsed());
+ List<ContainerReplica> otherReplicas =
+ getOtherReplicas(containerId, datanodeDetails);
Review comment:
I think we can skip filtering the replicas for "others", since the
resulting count/bytes values will be the min/max of all replicas, including
this one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
