rakeshadr commented on a change in pull request #1437: URL: https://github.com/apache/hadoop-ozone/pull/1437#discussion_r492481705
########## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/cache/OMMetadataCacheFactory.java ########## @@ -0,0 +1,120 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with this + * work for additional information regarding copyright ownership. The ASF + * licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * <p> + * http://www.apache.org/licenses/LICENSE-2.0 + * <p> + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS,WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations under + * the License. + */ +package org.apache.hadoop.ozone.om.cache; + +import org.apache.hadoop.hdds.conf.OzoneConfiguration; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +/** + * Provides different caching policies for cache entities. This can be + * extended by adding more entities and their caching policies into it. + * <p> + * For example, for the directory cache user has to configure following + * property with cache type. OM will creates specific cache store for the + * directory based on the configured cache policy. + * ozone.om.metadata.cache.directory = DIR_LRU + * <p> + * One can add new directory policy to OM by defining new cache type say + * "DIR_LFU" and implements new CacheStore as DirectoryLFUCacheStore. + * <p> + * One can add new entity to OM, let's say file to be cached by configuring the + * property like below and implement specific provider to instantiate the + * fileCacheStore. + * ozone.om.metadata.cache.file = FILE_LRU + */ +public final class OMMetadataCacheFactory { + private static final Logger LOG = + LoggerFactory.getLogger(OMMetadataCacheFactory.class); + + /** + * Private constructor, class is not meant to be initialized. + */ + private OMMetadataCacheFactory() { + } + + public static CacheStore getCache(String configuredCachePolicy, + String defaultValue, + OzoneConfiguration config) { + String cachePolicy = config.get(configuredCachePolicy, defaultValue); + LOG.info("Configured {} with {}", configuredCachePolicy, cachePolicy); + CacheEntity entity = getCacheEntity(configuredCachePolicy); + + switch (entity) { + case DIR: + OMMetadataCacheProvider provider = new OMDirectoryCacheProvider(config, + cachePolicy); + if (LOG.isDebugEnabled()) { + LOG.debug("CacheStore initialized with {}:" + provider.getEntity()); + } + return provider.getCache(); + default: + return null; Review comment: OK, will add UTs to cover this case. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org
