linyiqun commented on a change in pull request #1437:
URL: https://github.com/apache/hadoop-ozone/pull/1437#discussion_r492562181
##########
File path: hadoop-hdds/common/src/main/resources/ozone-default.xml
##########
@@ -2521,4 +2521,32 @@
filesystem semantics.
</description>
</property>
+
+ <property>
+ <name>ozone.om.metadata.cache.directory</name>
Review comment:
This name also needs to be updated, current unit test was broken by this
>
TestOzoneConfigurationFields>TestConfigurationFieldsBase.testCompareConfigurationClassAgainstXml:493
class org.apache.hadoop.ozone.OzoneConfigKeys class
org.apache.hadoop.hdds.scm.ScmConfigKeys class
org.apache.hadoop.ozone.om.OMConfigKeys class
org.apache.hadoop.hdds.HddsConfigKeys class
org.apache.hadoop.ozone.recon.ReconServerConfigKeys class
org.apache.hadoop.ozone.s3.S3GatewayConfigKeys class
org.apache.hadoop.hdds.scm.server.SCMHTTPServerConfig has 1 variables missing
in ozone-default.xml Entries: ozone.om.metadata.cache.directory.policy
expected:<0> but was:<1>
[ERROR]
TestOzoneConfigurationFields>TestConfigurationFieldsBase.testCompareXmlAgainstConfigurationClass
##########
File path:
hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/cache/TestOMMetadataCache.java
##########
@@ -0,0 +1,276 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ * <p>
+ * http://www.apache.org/licenses/LICENSE-2.0
+ * <p>
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.ozone.om.cache;
+
+import org.apache.hadoop.hdds.HddsConfigKeys;
+import org.apache.hadoop.hdds.conf.OzoneConfiguration;
+import org.apache.hadoop.ozone.om.OMConfigKeys;
+import org.apache.hadoop.ozone.om.OMMetadataManager;
+import org.apache.hadoop.ozone.om.OmMetadataManagerImpl;
+import org.apache.hadoop.test.GenericTestUtils;
+import org.junit.Assert;
+import org.junit.Before;
+import org.junit.Rule;
+import org.junit.Test;
+import org.junit.rules.Timeout;
+
+import java.io.File;
+import java.io.IOException;
+
+import static org.junit.Assert.assertTrue;
+import static org.junit.Assert.fail;
+
+/**
+ * Testing OMMetadata cache policy class.
+ */
+public class TestOMMetadataCache {
+
+ private OzoneConfiguration conf;
+ private OMMetadataManager omMetadataManager;
+
+ /**
+ * Set a timeout for each test.
+ */
+ @Rule
+ public Timeout timeout = new Timeout(100000);
+
+ @Before
+ public void setup() {
+ //initialize config
+ conf = new OzoneConfiguration();
+ }
+
+ @Test
+ public void testVerifyDirCachePolicies() {
+ //1. Verify disabling cache
+ conf.set(OMConfigKeys.OZONE_OM_CACHE_DIR_POLICY,
+ CachePolicy.DIR_NOCACHE.getPolicy());
+ CacheStore dirCacheStore = OMMetadataCacheFactory.getCache(
+ OMConfigKeys.OZONE_OM_CACHE_DIR_POLICY,
+ OMConfigKeys.OZONE_OM_CACHE_DIR_DEFAULT, conf);
+ Assert.assertEquals("Cache Policy mismatches!", CachePolicy.DIR_NOCACHE,
+ dirCacheStore.getCachePolicy());
+
+ //2. Invalid cache policy
+ conf.set(OMConfigKeys.OZONE_OM_CACHE_DIR_POLICY, "InvalidCachePolicy");
+ dirCacheStore = OMMetadataCacheFactory.getCache(
+ OMConfigKeys.OZONE_OM_CACHE_DIR_POLICY,
+ OMConfigKeys.OZONE_OM_CACHE_DIR_DEFAULT, conf);
+ Assert.assertEquals("Expected NullCache for an invalid CachePolicy",
+ CachePolicy.DIR_NOCACHE, dirCacheStore.getCachePolicy());
+
+ //3. Directory LRU cache policy
+ conf.set(OMConfigKeys.OZONE_OM_CACHE_DIR_POLICY,
+ OMConfigKeys.OZONE_OM_CACHE_DIR_DEFAULT);
+ dirCacheStore = OMMetadataCacheFactory.getCache(
+ OMConfigKeys.OZONE_OM_CACHE_DIR_POLICY,
+ OMConfigKeys.OZONE_OM_CACHE_DIR_DEFAULT, conf);
+ Assert.assertEquals("Cache Type mismatches!", CachePolicy.DIR_LRU,
+ dirCacheStore.getCachePolicy());
+ }
+
+ @Test
+ public void testLRUCacheDirectoryPolicy() throws IOException {
+ conf.set(OMConfigKeys.OZONE_OM_CACHE_DIR_POLICY,
+ CachePolicy.DIR_LRU.getPolicy());
+ conf.setInt(OMConfigKeys.OZONE_OM_CACHE_DIR_INIT_CAPACITY, 1);
+ conf.setLong(OMConfigKeys.OZONE_OM_CACHE_DIR_MAX_CAPACITY, 2);
+
+ File testDir = GenericTestUtils.getRandomizedTestDir();
+ conf.set(HddsConfigKeys.OZONE_METADATA_DIRS,
+ testDir.toString());
+
+ omMetadataManager = new OmMetadataManagerImpl(conf);
+ CacheStore dirCacheStore =
+ omMetadataManager.getOMCacheManager().getDirCache();
+ Assert.assertEquals("CachePolicy Mismatches!", CachePolicy.DIR_LRU,
+ dirCacheStore.getCachePolicy());
+
+ OMCacheKey<String> dirA = new OMCacheKey<>("512/a");
+ OMCacheValue<Long> dirAObjID = new OMCacheValue<>(1025L);
+ OMCacheKey<String> dirB = new OMCacheKey<>(dirAObjID + "/b");
+ OMCacheValue<Long> dirBObjID = new OMCacheValue<>(1026L);
+ dirCacheStore.put(dirA, dirAObjID);
+ dirCacheStore.put(dirB, dirBObjID);
+ // Step1. Cached Entries => {a, b}
+ Assert.assertEquals("Unexpected Cache Value",
+ dirAObjID.getCacheValue(),
dirCacheStore.get(dirA).getCacheValue());
+ Assert.assertEquals("Unexpected Cache Value",
+ dirBObjID.getCacheValue(),
dirCacheStore.get(dirB).getCacheValue());
+
+ // Step2. Verify eviction
+ // Cached Entries {frontEntry, rearEntry} => {c, b}
+ OMCacheKey<String> dirC = new OMCacheKey<>(dirBObjID + "/c");
+ OMCacheValue<Long> dirCObjID = new OMCacheValue<>(1027L);
+ dirCacheStore.put(dirC, dirCObjID);
+ Assert.assertEquals("Unexpected Cache Value",
+ dirCObjID.getCacheValue(),
dirCacheStore.get(dirC).getCacheValue());
+ Assert.assertNull("Unexpected Cache Value", dirCacheStore.get(dirA));
+
+ // Step3. Adding 'a' again. Now 'b' will be evicted.
+ dirCacheStore.put(dirA, dirAObjID);
+ // Cached Entries {frontEntry, rearEntry} => {a, c}
+ Assert.assertEquals("Unexpected Cache Value",
+ dirAObjID.getCacheValue(),
dirCacheStore.get(dirA).getCacheValue());
+ Assert.assertNull("Unexpected Cache Value", dirCacheStore.get(dirB));
+
+ // Step4. Cached Entries {frontEntry, rearEntry} => {c, a}
+ // Access 'c' so that the recently used entry will be 'c'. Now the entry
+ // eligible for eviction will be 'a'.
+ Assert.assertEquals("Unexpected Cache Value",
+ dirCObjID.getCacheValue(),
dirCacheStore.get(dirC).getCacheValue());
+
+ // Step4. Recently accessed entry will be retained.
+ dirCacheStore.put(dirB, dirBObjID);
+ // Cached Entries {frontEntry, rearEntry} => {b, c}
+ Assert.assertEquals("Unexpected Cache Value",
+ dirBObjID.getCacheValue(),
dirCacheStore.get(dirB).getCacheValue());
+ Assert.assertEquals("Unexpected Cache Value",
+ dirCObjID.getCacheValue(),
dirCacheStore.get(dirC).getCacheValue());
+ Assert.assertNull("Unexpected Cache Value", dirCacheStore.get(dirA));
+
+ // Step5. Add duplicate entries shouldn't make any eviction.
+ dirCacheStore.put(dirB, dirBObjID);
+ Assert.assertEquals("Unexpected Cache Value",
+ dirBObjID.getCacheValue(),
dirCacheStore.get(dirB).getCacheValue());
+ Assert.assertEquals("Unexpected Cache Value",
+ dirCObjID.getCacheValue(),
dirCacheStore.get(dirC).getCacheValue());
+ Assert.assertEquals("Incorrect cache size", 2, dirCacheStore.size());
+
+ // Step6. Verify entry removal. Remove recently accessed entry.
+ dirCacheStore.remove(dirC);
+ // duplicate removal shouldn't cause any issues
+ dirCacheStore.remove(dirC);
+ Assert.assertEquals("Unexpected Cache Value",
+ dirBObjID.getCacheValue(),
dirCacheStore.get(dirB).getCacheValue());
+ Assert.assertNull("Unexpected Cache Value", dirCacheStore.get(dirC));
+ Assert.assertEquals("Incorrect cache size", 1, dirCacheStore.size());
+
+ // Step7. Make it empty
+ dirCacheStore.remove(dirB);
+ Assert.assertEquals("Incorrect cache size", 0, dirCacheStore.size());
+ }
+
+ @Test
+ public void testNullKeysAndValuesToLRUCacheDirectoryPolicy() throws
IOException {
Review comment:
Checkstyle issue of long line length:
>[ERROR]
src/test/java/org/apache/hadoop/ozone/om/cache/TestOMMetadataCache.java:[170]
(sizes) LineLength: Line is longer than 80 characters (found 83).
##########
File path:
hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/cache/TestOMMetadataCache.java
##########
@@ -0,0 +1,276 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ * <p>
+ * http://www.apache.org/licenses/LICENSE-2.0
+ * <p>
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.ozone.om.cache;
+
+import org.apache.hadoop.hdds.HddsConfigKeys;
+import org.apache.hadoop.hdds.conf.OzoneConfiguration;
+import org.apache.hadoop.ozone.om.OMConfigKeys;
+import org.apache.hadoop.ozone.om.OMMetadataManager;
+import org.apache.hadoop.ozone.om.OmMetadataManagerImpl;
+import org.apache.hadoop.test.GenericTestUtils;
+import org.junit.Assert;
+import org.junit.Before;
+import org.junit.Rule;
+import org.junit.Test;
+import org.junit.rules.Timeout;
+
+import java.io.File;
+import java.io.IOException;
+
+import static org.junit.Assert.assertTrue;
+import static org.junit.Assert.fail;
+
+/**
+ * Testing OMMetadata cache policy class.
+ */
+public class TestOMMetadataCache {
+
+ private OzoneConfiguration conf;
+ private OMMetadataManager omMetadataManager;
+
+ /**
+ * Set a timeout for each test.
+ */
+ @Rule
+ public Timeout timeout = new Timeout(100000);
+
+ @Before
+ public void setup() {
+ //initialize config
+ conf = new OzoneConfiguration();
+ }
+
+ @Test
+ public void testVerifyDirCachePolicies() {
+ //1. Verify disabling cache
+ conf.set(OMConfigKeys.OZONE_OM_CACHE_DIR_POLICY,
+ CachePolicy.DIR_NOCACHE.getPolicy());
+ CacheStore dirCacheStore = OMMetadataCacheFactory.getCache(
+ OMConfigKeys.OZONE_OM_CACHE_DIR_POLICY,
+ OMConfigKeys.OZONE_OM_CACHE_DIR_DEFAULT, conf);
+ Assert.assertEquals("Cache Policy mismatches!", CachePolicy.DIR_NOCACHE,
+ dirCacheStore.getCachePolicy());
+
+ //2. Invalid cache policy
+ conf.set(OMConfigKeys.OZONE_OM_CACHE_DIR_POLICY, "InvalidCachePolicy");
+ dirCacheStore = OMMetadataCacheFactory.getCache(
+ OMConfigKeys.OZONE_OM_CACHE_DIR_POLICY,
+ OMConfigKeys.OZONE_OM_CACHE_DIR_DEFAULT, conf);
+ Assert.assertEquals("Expected NullCache for an invalid CachePolicy",
+ CachePolicy.DIR_NOCACHE, dirCacheStore.getCachePolicy());
+
+ //3. Directory LRU cache policy
+ conf.set(OMConfigKeys.OZONE_OM_CACHE_DIR_POLICY,
+ OMConfigKeys.OZONE_OM_CACHE_DIR_DEFAULT);
+ dirCacheStore = OMMetadataCacheFactory.getCache(
+ OMConfigKeys.OZONE_OM_CACHE_DIR_POLICY,
+ OMConfigKeys.OZONE_OM_CACHE_DIR_DEFAULT, conf);
+ Assert.assertEquals("Cache Type mismatches!", CachePolicy.DIR_LRU,
+ dirCacheStore.getCachePolicy());
+ }
+
+ @Test
+ public void testLRUCacheDirectoryPolicy() throws IOException {
+ conf.set(OMConfigKeys.OZONE_OM_CACHE_DIR_POLICY,
+ CachePolicy.DIR_LRU.getPolicy());
+ conf.setInt(OMConfigKeys.OZONE_OM_CACHE_DIR_INIT_CAPACITY, 1);
+ conf.setLong(OMConfigKeys.OZONE_OM_CACHE_DIR_MAX_CAPACITY, 2);
+
+ File testDir = GenericTestUtils.getRandomizedTestDir();
+ conf.set(HddsConfigKeys.OZONE_METADATA_DIRS,
+ testDir.toString());
+
+ omMetadataManager = new OmMetadataManagerImpl(conf);
+ CacheStore dirCacheStore =
+ omMetadataManager.getOMCacheManager().getDirCache();
+ Assert.assertEquals("CachePolicy Mismatches!", CachePolicy.DIR_LRU,
+ dirCacheStore.getCachePolicy());
+
+ OMCacheKey<String> dirA = new OMCacheKey<>("512/a");
+ OMCacheValue<Long> dirAObjID = new OMCacheValue<>(1025L);
+ OMCacheKey<String> dirB = new OMCacheKey<>(dirAObjID + "/b");
+ OMCacheValue<Long> dirBObjID = new OMCacheValue<>(1026L);
+ dirCacheStore.put(dirA, dirAObjID);
+ dirCacheStore.put(dirB, dirBObjID);
+ // Step1. Cached Entries => {a, b}
+ Assert.assertEquals("Unexpected Cache Value",
+ dirAObjID.getCacheValue(),
dirCacheStore.get(dirA).getCacheValue());
+ Assert.assertEquals("Unexpected Cache Value",
+ dirBObjID.getCacheValue(),
dirCacheStore.get(dirB).getCacheValue());
+
+ // Step2. Verify eviction
+ // Cached Entries {frontEntry, rearEntry} => {c, b}
+ OMCacheKey<String> dirC = new OMCacheKey<>(dirBObjID + "/c");
+ OMCacheValue<Long> dirCObjID = new OMCacheValue<>(1027L);
+ dirCacheStore.put(dirC, dirCObjID);
+ Assert.assertEquals("Unexpected Cache Value",
+ dirCObjID.getCacheValue(),
dirCacheStore.get(dirC).getCacheValue());
+ Assert.assertNull("Unexpected Cache Value", dirCacheStore.get(dirA));
+
+ // Step3. Adding 'a' again. Now 'b' will be evicted.
+ dirCacheStore.put(dirA, dirAObjID);
+ // Cached Entries {frontEntry, rearEntry} => {a, c}
+ Assert.assertEquals("Unexpected Cache Value",
+ dirAObjID.getCacheValue(),
dirCacheStore.get(dirA).getCacheValue());
+ Assert.assertNull("Unexpected Cache Value", dirCacheStore.get(dirB));
+
+ // Step4. Cached Entries {frontEntry, rearEntry} => {c, a}
+ // Access 'c' so that the recently used entry will be 'c'. Now the entry
+ // eligible for eviction will be 'a'.
+ Assert.assertEquals("Unexpected Cache Value",
+ dirCObjID.getCacheValue(),
dirCacheStore.get(dirC).getCacheValue());
+
+ // Step4. Recently accessed entry will be retained.
+ dirCacheStore.put(dirB, dirBObjID);
+ // Cached Entries {frontEntry, rearEntry} => {b, c}
+ Assert.assertEquals("Unexpected Cache Value",
+ dirBObjID.getCacheValue(),
dirCacheStore.get(dirB).getCacheValue());
+ Assert.assertEquals("Unexpected Cache Value",
+ dirCObjID.getCacheValue(),
dirCacheStore.get(dirC).getCacheValue());
+ Assert.assertNull("Unexpected Cache Value", dirCacheStore.get(dirA));
+
+ // Step5. Add duplicate entries shouldn't make any eviction.
+ dirCacheStore.put(dirB, dirBObjID);
+ Assert.assertEquals("Unexpected Cache Value",
+ dirBObjID.getCacheValue(),
dirCacheStore.get(dirB).getCacheValue());
+ Assert.assertEquals("Unexpected Cache Value",
+ dirCObjID.getCacheValue(),
dirCacheStore.get(dirC).getCacheValue());
+ Assert.assertEquals("Incorrect cache size", 2, dirCacheStore.size());
+
+ // Step6. Verify entry removal. Remove recently accessed entry.
+ dirCacheStore.remove(dirC);
+ // duplicate removal shouldn't cause any issues
+ dirCacheStore.remove(dirC);
+ Assert.assertEquals("Unexpected Cache Value",
+ dirBObjID.getCacheValue(),
dirCacheStore.get(dirB).getCacheValue());
+ Assert.assertNull("Unexpected Cache Value", dirCacheStore.get(dirC));
+ Assert.assertEquals("Incorrect cache size", 1, dirCacheStore.size());
+
+ // Step7. Make it empty
+ dirCacheStore.remove(dirB);
+ Assert.assertEquals("Incorrect cache size", 0, dirCacheStore.size());
+ }
+
+ @Test
+ public void testNullKeysAndValuesToLRUCacheDirectoryPolicy() throws
IOException {
+ conf.set(OMConfigKeys.OZONE_OM_CACHE_DIR_POLICY,
+ CachePolicy.DIR_LRU.getPolicy());
+ conf.setInt(OMConfigKeys.OZONE_OM_CACHE_DIR_INIT_CAPACITY, 1);
+ conf.setLong(OMConfigKeys.OZONE_OM_CACHE_DIR_MAX_CAPACITY, 2);
+
+ File testDir = GenericTestUtils.getRandomizedTestDir();
+ conf.set(HddsConfigKeys.OZONE_METADATA_DIRS,
+ testDir.toString());
+
+ omMetadataManager = new OmMetadataManagerImpl(conf);
+ CacheStore dirCacheStore =
+ omMetadataManager.getOMCacheManager().getDirCache();
+ Assert.assertEquals("CachePolicy Mismatches!", CachePolicy.DIR_LRU,
+ dirCacheStore.getCachePolicy());
+
+ OMCacheKey<String> dirA = new OMCacheKey<>("512/a");
+ OMCacheValue<Long> dirAObjID = new OMCacheValue<>(1026L);
+ // shouldn't throw NPE, just skip null key
+ dirCacheStore.put(null, dirAObjID);
+ dirCacheStore.put(dirA, null);
+
+ // shouldn't throw NPE, just skip null key
+ Assert.assertNull("Unexpected value!", dirCacheStore.get(null));
+
+ // shouldn't throw NPE, just skip null key
+ dirCacheStore.remove(null);
+ }
+
+ @Test
+ public void testNoCacheDirectoryPolicy() throws IOException {
+ conf.set(OMConfigKeys.OZONE_OM_CACHE_DIR_POLICY,
+ CachePolicy.DIR_NOCACHE.getPolicy());
+
+ File testDir = GenericTestUtils.getRandomizedTestDir();
+ conf.set(HddsConfigKeys.OZONE_METADATA_DIRS,
+ testDir.toString());
+
+ omMetadataManager = new OmMetadataManagerImpl(conf);
+ CacheStore dirCacheStore =
+ omMetadataManager.getOMCacheManager().getDirCache();
+ Assert.assertEquals("CachePolicy Mismatches!", CachePolicy.DIR_NOCACHE,
+ dirCacheStore.getCachePolicy());
+
+ // Verify caching
+ OMCacheKey<String> dirA = new OMCacheKey<>("512/a");
+ OMCacheValue<Long> dirAObjID = new OMCacheValue<>(1025L);
+ dirCacheStore.put(dirA, dirAObjID);
+ Assert.assertNull("Unexpected Cache Value", dirCacheStore.get(dirA));
+ }
+
+ @Test
+ public void testDefaultCacheDirectoryPolicy() throws IOException {
+ File testDir = GenericTestUtils.getRandomizedTestDir();
+ conf.set(HddsConfigKeys.OZONE_METADATA_DIRS,
+ testDir.toString());
+
+ //1. Verify default dir cache policy. Defaulting to DIR_LRU
+ conf.unset(OMConfigKeys.OZONE_OM_CACHE_DIR_POLICY);
+ Assert.assertNull("Unexpected CachePolicy, it should be null!",
+ conf.get(OMConfigKeys.OZONE_OM_CACHE_DIR_POLICY));
+
+ omMetadataManager = new OmMetadataManagerImpl(conf);
+ CacheStore dirCacheStore =
+ omMetadataManager.getOMCacheManager().getDirCache();
+ Assert.assertEquals("CachePolicy Mismatches!", CachePolicy.DIR_LRU,
+ dirCacheStore.getCachePolicy());
+ }
+
+ @Test
+ public void testInvalidCacheDirectoryPolicyValue() throws IOException {
+ File testDir = GenericTestUtils.getRandomizedTestDir();
+ conf.set(HddsConfigKeys.OZONE_METADATA_DIRS,
+ testDir.toString());
+
+ //1. Verify default dir cache policy. Defaulting to DIR_NOCACHE
+ conf.set(OMConfigKeys.OZONE_OM_CACHE_DIR_POLICY, "INVALID");
+ Assert.assertEquals("Unexpected CachePolicy!", "INVALID",
+ conf.get(OMConfigKeys.OZONE_OM_CACHE_DIR_POLICY));
+
+ omMetadataManager = new OmMetadataManagerImpl(conf);
+ CacheStore dirCacheStore =
+ omMetadataManager.getOMCacheManager().getDirCache();
+ Assert.assertEquals("CachePolicy Mismatches!", CachePolicy.DIR_NOCACHE,
+ dirCacheStore.getCachePolicy());
+ }
+
+ @Test
+ public void testInvalidCacheDirectoryPolicyConfigurationName() throws
IOException {
Review comment:
Checkstyle issue of long line length
>[ERROR]
src/test/java/org/apache/hadoop/ozone/om/cache/TestOMMetadataCache.java:[258]
(sizes) LineLength: Line is longer than 80 characters (found 85).
##########
File path:
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/OMConfigKeys.java
##########
@@ -246,4 +246,15 @@ private OMConfigKeys() {
"ozone.om.enable.filesystem.paths";
public static final boolean OZONE_OM_ENABLE_FILESYSTEM_PATHS_DEFAULT =
false;
+
+ public static final String OZONE_OM_CACHE_DIR_POLICY =
+ "ozone.om.metadata.cache.directory";
+ public static final String OZONE_OM_CACHE_DIR_DEFAULT = "DIR_LRU";
Review comment:
Looks like OZONE_OM_CACHE_DIR_DEFAULT was not updated to
OZONE_OM_CACHE_DIR_POLICY_DEFAULT.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org
