linyiqun commented on a change in pull request #1430: URL: https://github.com/apache/hadoop-ozone/pull/1430#discussion_r492798607
########## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java ########## @@ -994,6 +1005,45 @@ public static boolean omInit(OzoneConfiguration conf) throws IOException, } } + public boolean applyAllPendingTransactions() + throws InterruptedException, IOException { + + if (!isRatisEnabled) { + LOG.info("Ratis not enabled. Nothing to do."); + return true; + } + + String purgeConfig = omRatisServer.getServer() + .getProperties().get(PURGE_UPTO_SNAPSHOT_INDEX_KEY); + if (!Boolean.parseBoolean(purgeConfig)) { + throw new IllegalStateException("Cannot prepare OM for Upgrade since " + + "raft.server.log.purge.upto.snapshot.index is not true"); + } + + waitForAllTxnsApplied(omRatisServer.getOmStateMachine(), + omRatisServer.getRaftGroup(), + (RaftServerProxy) omRatisServer.getServer(), + TimeUnit.MINUTES.toSeconds(5)); Review comment: >Also in 5 minutes I would expect in all cases that the unapplied transactions can be applied, as the number of this kind of transactions should not be too much as far as I know, or if it is then the system is not healthy anyway. I'm okay to let 5 mins as current threshold wait time, only one minor comment: can we define a variable for this time value rather hard-coded in method here? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org