hanishakoneru commented on a change in pull request #1430:
URL: https://github.com/apache/hadoop-ozone/pull/1430#discussion_r492845659



##########
File path: 
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java
##########
@@ -994,6 +1005,45 @@ public static boolean omInit(OzoneConfiguration conf) 
throws IOException,
     }
   }
 
+  public boolean applyAllPendingTransactions()
+      throws InterruptedException, IOException {
+
+    if (!isRatisEnabled) {
+      LOG.info("Ratis not enabled. Nothing to do.");
+      return true;
+    }
+
+    String purgeConfig = omRatisServer.getServer()
+        .getProperties().get(PURGE_UPTO_SNAPSHOT_INDEX_KEY);
+    if (!Boolean.parseBoolean(purgeConfig)) {
+      throw new IllegalStateException("Cannot prepare OM for Upgrade since  " +
+          "raft.server.log.purge.upto.snapshot.index is not true");
+    }

Review comment:
       OMRatisServer always sets this property to true. It is not configurable. 
Is this check still needed?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org

Reply via email to