On Thu, 2011-03-03 at 10:55 +0100, Florian Haas wrote: > On 2011-03-03 10:43, Holger Teutsch wrote: > > Hi, > > I submit a patch for > > "bugzilla 2541: Shell should warn if parameter uniqueness is violated" > > for discussion. > > I'll leave it do Dejan to review the code, but I love the functionality. > Thanks a lot for tackling this. My only suggestion for an improvement is > to make the warning message a bit more terse, as in: > > WARNING: Resources ip1a, ip1b violate uniqueness for parameter "ip": > "1.2.3.4" >
Florian, I see your point. Although my formatting allows for an unlimited number of collisions ( 8-) ) in real life we will only have 2 or 3. Will change this together with Dejan's hints. > Cheers, > Florian > > _______________________________________________ > Pacemaker mailing list: Pacemaker@oss.clusterlabs.org > http://oss.clusterlabs.org/mailman/listinfo/pacemaker > > Project Home: http://www.clusterlabs.org > Getting started: http://www.clusterlabs.org/doc/Cluster_from_Scratch.pdf > Bugs: > http://developerbugs.linux-foundation.org/enter_bug.cgi?product=Pacemaker _______________________________________________ Pacemaker mailing list: Pacemaker@oss.clusterlabs.org http://oss.clusterlabs.org/mailman/listinfo/pacemaker Project Home: http://www.clusterlabs.org Getting started: http://www.clusterlabs.org/doc/Cluster_from_Scratch.pdf Bugs: http://developerbugs.linux-foundation.org/enter_bug.cgi?product=Pacemaker
