Hi Hideo-san,
On Wed, Mar 06, 2013 at 10:37:44AM +0900, renayama19661...@ybb.ne.jp wrote:
> Hi Dejan,
> Hi Andrew,
>
> As for the crm shell, the check of the meta attribute was revised with the
> next patch.
>
> * http://hg.savannah.gnu.org/hgweb/crmsh/rev/d1174f42f4b3
>
> This patch was backported in Pacemaker1.0.13.
>
> *
> https://github.com/ClusterLabs/pacemaker-1.0/commit/fa1a99ab36e0ed015f1bcbbb28f7db962a9d1abc#shell/modules/cibconfig.py
>
> However, the ordered,colocated attribute of the group resource is treated as
> an error when I use crm Shell which adopted this patch.
>
> --------------------------------------
> (snip)
> ### Group Configuration ###
> group master-group \
> vip-master \
> vip-rep \
> meta \
> ordered="false"
> (snip)
>
> [root@rh63-heartbeat1 ~]# crm configure load update test2339.crm
> INFO: building help index
> crm_verify[20028]: 2013/03/06_17:57:18 WARN: unpack_nodes: Blind faith: not
> fencing unseen nodes
> WARNING: vip-master: specified timeout 60s for start is smaller than the
> advised 90
> WARNING: vip-master: specified timeout 60s for stop is smaller than the
> advised 100
> WARNING: vip-rep: specified timeout 60s for start is smaller than the advised
> 90
> WARNING: vip-rep: specified timeout 60s for stop is smaller than the advised
> 100
> ERROR: master-group: attribute ordered does not exist -----> WHY?
> Do you still want to commit? y
> --------------------------------------
>
> If it chooses `yes` by a confirmation message, it is reflected, but it is a
> problem that error message is displayed.
> * The error occurs in the same way when I appoint colocated attribute.
> And....I noticed that there was not explanation of ordered,colocated of the
> group resource in online help of Pacemaker.
>
> I think that the designation of the ordered,colocated attribute should not
> become the error in group resource.
> In addition, I think that ordered,colocated should be added to online help.
These attributes are not listed in crmsh. Does the attached patch
help?
Thanks,
Dejan
>
> Best Regards,
> Hideo Yamauchi.
>
>
> _______________________________________________
> Pacemaker mailing list: Pacemaker@oss.clusterlabs.org
> http://oss.clusterlabs.org/mailman/listinfo/pacemaker
>
> Project Home: http://www.clusterlabs.org
> Getting started: http://www.clusterlabs.org/doc/Cluster_from_Scratch.pdf
> Bugs: http://bugs.clusterlabs.org
>From 1f6ed514c8e53c79835aaaf26d152f2d840126f0 Mon Sep 17 00:00:00 2001
From: Dejan Muhamedagic <de...@suse.de>
Date: Wed, 6 Mar 2013 11:57:54 +0100
Subject: [PATCH] Low: shell: add group meta attributes
---
shell/modules/cibconfig.py | 2 ++
shell/modules/vars.py.in | 1 +
2 files changed, 3 insertions(+)
diff --git a/shell/modules/cibconfig.py b/shell/modules/cibconfig.py
index 2dfaa92..1cf08fa 100644
--- a/shell/modules/cibconfig.py
+++ b/shell/modules/cibconfig.py
@@ -1152,6 +1152,8 @@ class CibContainer(CibObject):
l += vars.clone_meta_attributes
elif self.obj_type == "ms":
l += vars.clone_meta_attributes + vars.ms_meta_attributes
+ elif self.obj_type == "group":
+ l += vars.group_meta_attributes
rc = sanity_check_meta(self.obj_id,self.node,l)
return rc
diff --git a/shell/modules/vars.py.in b/shell/modules/vars.py.in
index c83232e..dff86dc 100644
--- a/shell/modules/vars.py.in
+++ b/shell/modules/vars.py.in
@@ -117,6 +117,7 @@ class Vars(Singleton):
"failure-timeout", "resource-stickiness", "target-role",
"restart-type", "description",
)
+ group_meta_attributes = ("ordered", "colocated")
clone_meta_attributes = (
"ordered", "notify", "interleave", "globally-unique",
"clone-max", "clone-node-max", "clone-state", "description",
--
1.8.0
_______________________________________________
Pacemaker mailing list: Pacemaker@oss.clusterlabs.org
http://oss.clusterlabs.org/mailman/listinfo/pacemaker
Project Home: http://www.clusterlabs.org
Getting started: http://www.clusterlabs.org/doc/Cluster_from_Scratch.pdf
Bugs: http://bugs.clusterlabs.org
