https://bugzilla.redhat.com/show_bug.cgi?id=834516
Petr Pisar <ppi...@redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|fedora-review? |fedora-review+
--- Comment #3 from Petr Pisar <ppi...@redhat.com> ---
Spec file changes:
--- perl-Devel-StringInfo.spec.old 2012-06-22 10:00:53.000000000 +0200
+++ perl-Devel-StringInfo.spec 2012-06-22 15:41:42.000000000 +0200
@@ -2,7 +2,7 @@
Version: 0.04
Release: 1%{?dist}
Summary: Gather information about strings
-License: GPL+ or Artistic
+License: GPL+ or Artistic or MIT
Group: Development/Libraries
URL: http://search.cpan.org/dist/Devel-StringInfo/
Source0:
http://www.cpan.org/authors/id/N/NU/NUFFIN/Devel-StringInfo-%{version}.tar.gz
@@ -20,6 +20,8 @@
BuildRequires: perl(Tie::IxHash)
BuildRequires: perl(YAML)
Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo
$version))
+Requires: perl(Data::HexDump::XXD)
+Requires: perl(YAML)
%description
This module is a debugging aid that helps figure out more information
@@ -33,8 +35,6 @@
make %{?_smp_mflags}
%install
-rm -rf $RPM_BUILD_ROOT
-
make pure_install PERL_INSTALL_ROOT=$RPM_BUILD_ROOT
find $RPM_BUILD_ROOT -type f -name .packlist -exec rm -f {} \;
> FIX: Add `or MIT' to the licenses (lib/Devel/StringInfo.pm).
-License: GPL+ or Artistic
+License: GPL+ or Artistic or MIT
Ok.
> FIX: Run-require `perl(YAML)' (lib/Devel/StringInfo.pm:77).
+Requires: perl(YAML)
Ok.
> FIX: Run-require `perl(Data::HexDump::XXD)' (lib/Devel/StringInfo.pm:91).
+Requires: perl(Data::HexDump::XXD)
Ok.
$ rpm -q --requires -p
../RPMS/noarch/perl-Devel-StringInfo-0.04-1.fc18.noarch.rpm |sort |uniq -c
1 perl(Data::HexDump::XXD)
1 perl(Encode)
1 perl(Encode::Guess)
1 perl(:MODULE_COMPAT_5.14.2)
1 perl(Moose)
1 perl(namespace::clean)
1 perl(Scalar::Util)
1 perl(Sub::Exporter)
1 perl(Tie::IxHash)
1 perl(utf8)
1 perl(YAML)
1 rpmlib(CompressedFileNames) <= 3.0.4-1
1 rpmlib(FileDigests) <= 4.6.0-1
1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.
Package builds in F18
(http://koji.fedoraproject.org/koji/taskinfo?taskID=4188268). Ok.
Resolution: Package APPROVED.
--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
